Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1008363002: Promote code from code cache to compilation cache. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Promote code from code cache to compilation cache. The per-isolate compilation cache is a lot faster still than the serialized code cache. Promote code to compilation cache after deserialization. R=vogelheim@chromium.org BUG=chromium:399580 LOG=N Committed: https://crrev.com/567e45a1927c123838ba76e5483ed6177d055275 Cr-Commit-Position: refs/heads/master@{#27220}

Patch Set 1 #

Patch Set 2 : improve test case slightly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M src/compiler.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 9 months ago (2015-03-16 12:01:29 UTC) #1
vogelheim
lgtm
5 years, 9 months ago (2015-03-16 12:26:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008363002/20001
5 years, 9 months ago (2015-03-16 12:29:45 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 13:19:17 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 13:19:31 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/567e45a1927c123838ba76e5483ed6177d055275
Cr-Commit-Position: refs/heads/master@{#27220}

Powered by Google App Engine
This is Rietveld 408576698