bindings: Reduces the binary size by reducing # of callback functions.

Source/bindings/templates/attributes.cpp

 {% from 'conversions.cpp' import v8_value_to_local_cpp_value %}
 
 
 {##############################################################################}
 {% macro attribute_getter(attribute, world_suffix) %}
 {% filter conditional(attribute.conditional_string) %}
 static void {{attribute.name}}AttributeGetter{{world_suffix}}(
 {%- if attribute.is_expose_js_accessors %}
 const v8::FunctionCallbackInfo<v8::Value>& info
 {%- else %}
@@ skipping 180 matching lines @@
 v8::Local<v8::Name> property, const v8::PropertyCallbackInfo<v8::Value>& info
 {%- endif %})
 {
     TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");
     {% if attribute.deprecate_as %}
     UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}});
     {% endif %}
     {% if attribute.measure_as %}
     UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{attribute.measure_as('ConstructorGetter')}});
     {% endif %}
-    {% if attribute.is_expose_js_accessors %}
-    v8ConstructorAttributeGetterAsAccessor(info);
-    {% else %}
-    v8ConstructorAttributeGetterAsProperty(property, info);
-    {% endif %}
+    v8ConstructorAttributeGetter(property, info);
     TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
 }
 {% endfilter %}
 {% endmacro %}
 
 
 {##############################################################################}
 {% macro attribute_setter(attribute, world_suffix) %}
 {% filter conditional(attribute.conditional_string) %}
 static void {{attribute.name}}AttributeSetter{{world_suffix}}(
@@ skipping 182 matching lines @@
     v8::Local<v8::Value> holder = toV8(holderImpl, scriptState->context()->Global(), scriptState->isolate());
 
     ExceptionState exceptionState(ExceptionState::SetterContext, "{{attribute.name}}", "{{cpp_class}}", scriptState->context()->Global(), scriptState->isolate());
     return PrivateScriptRunner::runDOMAttributeSetter(scriptState, scriptStateInUserScript, "{{cpp_class}}", "{{attribute.name}}", holder, {{attribute.private_script_cpp_value_to_v8_value}});
 }
 {% endmacro %}
 
 
 {##############################################################################}
 {% macro attribute_configuration(attribute) %}
+{% if attribute.constructor_type %}
 {% set getter_callback =
-       '%sV8Internal::%sAttributeGetterCallback' %
-           (cpp_class_or_partial, attribute.name)
-       if not attribute.constructor_type else (
-       '%sV8Internal::%sConstructorGetterCallback' %
-           (cpp_class_or_partial, attribute.name)
-       if attribute.needs_constructor_getter_callback else (
-       'v8ConstructorAttributeGetterAsAccessor'
-       if attribute.is_expose_js_accessors else (
-       'v8ConstructorAttributeGetterAsProperty'))) %}
-{% set getter_callback_for_main_world =
-       '%sV8Internal::%sAttributeGetterCallbackForMainWorld' %
-           (cpp_class_or_partial, attribute.name)
-       if attribute.is_per_world_bindings else '0' %}
+       '%sV8Internal::%sConstructorGetterCallback' % (cpp_class_or_partial, attribute.name)
+       if attribute.needs_constructor_getter_callback else
+       'v8ConstructorAttributeGetter' %}
 {% set setter_callback =
-       '%sV8Internal::%sAttributeSetterCallback' %
+       '%sV8Internal::%sAttributeSetterCallback' % (cpp_class_or_partial, attribute.name)
+       if attribute.needs_constructor_setter_callback else
+       '%sV8Internal::%sConstructorAttributeSetterCallback' % (cpp_class_or_partial, cpp_class) %}
+{% else %}{# regular attributes #}
+{% set getter_callback = '%sV8Internal::%sAttributeGetterCallback' %
+           (cpp_class_or_partial, attribute.name) %}
+{% set setter_callback = '%sV8Internal::%sAttributeSetterCallback' %
            (cpp_class_or_partial, attribute.name)
        if attribute.has_setter else '0' %}
+{% endif %}
+{% set getter_callback_for_main_world =
+       '%sForMainWorld' % getter_callback
+       if attribute.is_per_world_bindings else '0' %}
 {% set setter_callback_for_main_world =
-       '%sV8Internal::%sAttributeSetterCallbackForMainWorld' %
-           (cpp_class_or_partial, attribute.name)
+       '%sForMainWorld' % setter_callback
        if attribute.is_per_world_bindings and attribute.has_setter else '0' %}
 {% set wrapper_type_info =
        'const_cast<WrapperTypeInfo*>(&V8%s::wrapperTypeInfo)' %
            attribute.constructor_type
        if attribute.constructor_type else '0' %}
 {% set access_control = 'static_cast<v8::AccessControl>(%s)' %
                         ' | '.join(attribute.access_control_list) %}
 {% set property_attribute = 'static_cast<v8::PropertyAttribute>(%s)' %
                             ' | '.join(attribute.property_attributes) %}
-{% set only_exposed_to_private_script = 'V8DOMConfiguration::OnlyExposedToPrivateScript' if attribute.only_exposed_to_private_script else 'V8DOMConfiguration::ExposedToAllScripts' %}
+{% set only_exposed_to_private_script =
+       'V8DOMConfiguration::OnlyExposedToPrivateScript'
+       if attribute.only_exposed_to_private_script else
+       'V8DOMConfiguration::ExposedToAllScripts' %}
 {% set on_prototype = 'V8DOMConfiguration::OnPrototype'
        if interface_name == 'Window' and attribute.idl_type == 'EventHandler'
        else 'V8DOMConfiguration::OnInstance' %}
 {% set attribute_configuration_list = [
        '"%s"' % attribute.name,
        getter_callback,
        setter_callback,
        getter_callback_for_main_world,
        setter_callback_for_main_world,
        wrapper_type_info,
        access_control,
        property_attribute,
        only_exposed_to_private_script,
    ] %}
 {% if not attribute.is_expose_js_accessors %}
 {% set attribute_configuration_list = attribute_configuration_list
                                     + [on_prototype] %}
 {% endif %}
 {{'{'}}{{attribute_configuration_list | join(', ')}}{{'}'}}
 {%- endmacro %}