bindings: Reduces the binary size by reducing # of callback functions.

Source/bindings/templates/attributes.cpp

 {% from 'conversions.cpp' import v8_value_to_local_cpp_value %}
 
 
 {##############################################################################}
 {% macro attribute_getter(attribute, world_suffix) %}
 {% filter conditional(attribute.conditional_string) %}
 static void {{attribute.name}}AttributeGetter{{world_suffix}}(
 {%- if attribute.is_expose_js_accessors %}
 const v8::FunctionCallbackInfo<v8::Value>& info
 {%- else %}
@@ skipping 401 matching lines @@
            (cpp_class_or_partial, attribute.name)
        if attribute.needs_constructor_getter_callback else (
        'v8ConstructorAttributeGetterAsAccessor'
        if attribute.is_expose_js_accessors else (
        'v8ConstructorAttributeGetterAsProperty'))) %}
 {% set getter_callback_for_main_world =
        '%sV8Internal::%sAttributeGetterCallbackForMainWorld' %
            (cpp_class_or_partial, attribute.name)
        if attribute.is_per_world_bindings else '0' %}
 {% set setter_callback =
+       '0' if not attribute.has_setter else (
+       '%sV8Internal::%sConstructorAttributeSetterCallbackAsProperty' %
+           (cpp_class_or_partial, cpp_class)
+       if (attribute.constructor_type and
+           attribute.name == attribute.constructor_type and
+           not attribute.is_expose_js_accessors) else (
+       '%sV8Internal::%sConstructorAttributeSetterCallbackAsAccessor' %
+           (cpp_class_or_partial, cpp_class)
+       if (attribute.constructor_type and
+           attribute.name == attribute.constructor_type and
+           attribute.is_expose_js_accessors) else (

[haraken, 2015/03/17 00:06:07]

Can we clean up these branches somehow? It looks too complicated.

[Yuki, 2015/03/17 08:35:19]

Tried my best.

        '%sV8Internal::%sAttributeSetterCallback' %
-           (cpp_class_or_partial, attribute.name)
-       if attribute.has_setter else '0' %}
+           (cpp_class_or_partial, attribute.name)))) %}
 {% set setter_callback_for_main_world =
        '%sV8Internal::%sAttributeSetterCallbackForMainWorld' %
            (cpp_class_or_partial, attribute.name)
        if attribute.is_per_world_bindings and attribute.has_setter else '0' %}
 {% set wrapper_type_info =
        'const_cast<WrapperTypeInfo*>(&V8%s::wrapperTypeInfo)' %
            attribute.constructor_type
        if attribute.constructor_type else '0' %}
 {% set access_control = 'static_cast<v8::AccessControl>(%s)' %
                         ' | '.join(attribute.access_control_list) %}
@@ skipping 13 matching lines @@
        access_control,
        property_attribute,
        only_exposed_to_private_script,
    ] %}
 {% if not attribute.is_expose_js_accessors %}
 {% set attribute_configuration_list = attribute_configuration_list
                                     + [on_prototype] %}
 {% endif %}
 {{'{'}}{{attribute_configuration_list | join(', ')}}{{'}'}}
 {%- endmacro %}