Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1008343002:
Add more languages with Arabic script to font selection (Closed)
DescriptionAdd more languages with Arabic script to font selection
Based on https://bug1123497.bugzilla.mozilla.org/attachment.cgi?id=8554372
on https://bugzilla.mozilla.org/show_bug.cgi?id=1123497
BUG=451385
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192205
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 10 (3 generated)
ebraminio@gmail.com changed reviewers: + behdad@google.com, eae@chromium.org, roozbeh@google.com
PTAL
At least the first entry is wrong. "ae" is for Avestan, which is not written in Arabic. On Mar 16, 2015 4:51 AM, <ebraminio@gmail.com> wrote: > Reviewers: eae, behdad_google, Roozbeh, > > Message: > PTAL > > Description: > Add more languages with Arabic script to font selection > > Based on https://bug1123497.bugzilla.mozilla.org/attachment.cgi?id=8554372 > on https://bugzilla.mozilla.org/show_bug.cgi?id=1123497 > > BUG=451385 > > Please review this at https://codereview.chromium.org/1008343002/ > > Base URL: https://chromium.googlesource.com/chromium/blink.git@master > > Affected files (+43, -0 lines): > M Source/platform/text/LocaleToScriptMapping.cpp > > > Index: Source/platform/text/LocaleToScriptMapping.cpp > diff --git a/Source/platform/text/LocaleToScriptMapping.cpp > b/Source/platform/text/LocaleToScriptMapping.cpp > index b2f56081f1b8a229a145db4c4aa5e567c7e0c9c0.. > 24a4250bb7a1255f0ed005eb8acf10d98ee9fbec 100644 > --- a/Source/platform/text/LocaleToScriptMapping.cpp > +++ b/Source/platform/text/LocaleToScriptMapping.cpp > @@ -181,32 +181,47 @@ UScriptCode localeToScriptCodeForFontSelection(const > String& locale) > { "aa", USCRIPT_LATIN }, > { "ab", USCRIPT_CYRILLIC }, > { "ady", USCRIPT_CYRILLIC }, > + { "ae", USCRIPT_ARABIC }, > { "af", USCRIPT_LATIN }, > { "ak", USCRIPT_LATIN }, > { "am", USCRIPT_ETHIOPIC }, > { "ar", USCRIPT_ARABIC }, > + { "arq", USCRIPT_ARABIC }, > + { "ary", USCRIPT_ARABIC }, > + { "arz", USCRIPT_ARABIC }, > { "as", USCRIPT_BENGALI }, > { "ast", USCRIPT_LATIN }, > { "av", USCRIPT_CYRILLIC }, > { "ay", USCRIPT_LATIN }, > { "az", USCRIPT_LATIN }, > + { "azb", USCRIPT_ARABIC }, > { "ba", USCRIPT_CYRILLIC }, > + { "bal", USCRIPT_ARABIC }, > { "be", USCRIPT_CYRILLIC }, > + { "bej", USCRIPT_ARABIC }, > { "bg", USCRIPT_CYRILLIC }, > { "bi", USCRIPT_LATIN }, > { "bn", USCRIPT_BENGALI }, > { "bo", USCRIPT_TIBETAN }, > + { "bqi", USCRIPT_ARABIC }, > + { "brh", USCRIPT_ARABIC }, > { "bs", USCRIPT_LATIN }, > { "ca", USCRIPT_LATIN }, > { "ce", USCRIPT_CYRILLIC }, > { "ceb", USCRIPT_LATIN }, > { "ch", USCRIPT_LATIN }, > { "chk", USCRIPT_LATIN }, > + { "cja", USCRIPT_ARABIC }, > + { "cjm", USCRIPT_ARABIC }, > + { "ckb", USCRIPT_ARABIC }, > { "cs", USCRIPT_LATIN }, > { "cy", USCRIPT_LATIN }, > { "da", USCRIPT_LATIN }, > + { "dcc", USCRIPT_ARABIC }, > { "de", USCRIPT_LATIN }, > + { "doi", USCRIPT_ARABIC }, > { "dv", USCRIPT_THAANA }, > + { "dyo", USCRIPT_ARABIC }, > { "dz", USCRIPT_TIBETAN }, > { "ee", USCRIPT_LATIN }, > { "efi", USCRIPT_LATIN }, > @@ -225,17 +240,25 @@ UScriptCode localeToScriptCodeForFontSelection(const > String& locale) > { "fy", USCRIPT_LATIN }, > { "ga", USCRIPT_LATIN }, > { "gaa", USCRIPT_LATIN }, > + { "gba", USCRIPT_ARABIC }, > + { "gbz", USCRIPT_ARABIC }, > { "gd", USCRIPT_LATIN }, > { "gil", USCRIPT_LATIN }, > { "gl", USCRIPT_LATIN }, > + { "gjk", USCRIPT_ARABIC }, > + { "gju", USCRIPT_ARABIC }, > + { "glk", USCRIPT_ARABIC }, > { "gn", USCRIPT_LATIN }, > { "gsw", USCRIPT_LATIN }, > { "gu", USCRIPT_GUJARATI }, > { "ha", USCRIPT_LATIN }, > { "haw", USCRIPT_LATIN }, > + { "haz", USCRIPT_ARABIC }, > { "he", USCRIPT_HEBREW }, > { "hi", USCRIPT_DEVANAGARI }, > { "hil", USCRIPT_LATIN }, > + { "hnd", USCRIPT_ARABIC }, > + { "hno", USCRIPT_ARABIC }, > { "ho", USCRIPT_LATIN }, > { "hr", USCRIPT_LATIN }, > { "ht", USCRIPT_LATIN }, > @@ -256,6 +279,7 @@ UScriptCode localeToScriptCodeForFontSelection(const > String& locale) > { "kam", USCRIPT_LATIN }, > { "kbd", USCRIPT_CYRILLIC }, > { "kha", USCRIPT_LATIN }, > + { "khw", USCRIPT_ARABIC }, > { "kk", USCRIPT_CYRILLIC }, > { "kl", USCRIPT_LATIN }, > { "km", USCRIPT_KHMER }, > @@ -268,17 +292,23 @@ UScriptCode localeToScriptCodeForFontSelection(const > String& locale) > { "ks", USCRIPT_ARABIC }, > { "ku", USCRIPT_ARABIC }, > { "kum", USCRIPT_CYRILLIC }, > + { "kvx", USCRIPT_ARABIC }, > + { "kxp", USCRIPT_ARABIC }, > { "ky", USCRIPT_CYRILLIC }, > { "la", USCRIPT_LATIN }, > { "lah", USCRIPT_ARABIC }, > { "lb", USCRIPT_LATIN }, > { "lez", USCRIPT_CYRILLIC }, > + { "lki", USCRIPT_ARABIC }, > { "ln", USCRIPT_LATIN }, > { "lo", USCRIPT_LAO }, > + { "lrc", USCRIPT_ARABIC }, > { "lt", USCRIPT_LATIN }, > + { "luz", USCRIPT_ARABIC }, > { "lv", USCRIPT_LATIN }, > { "mai", USCRIPT_DEVANAGARI }, > { "mdf", USCRIPT_CYRILLIC }, > + { "mfa", USCRIPT_ARABIC }, > { "mg", USCRIPT_LATIN }, > { "mh", USCRIPT_LATIN }, > { "mi", USCRIPT_LATIN }, > @@ -288,8 +318,10 @@ UScriptCode localeToScriptCodeForFontSelection(const > String& locale) > { "mr", USCRIPT_DEVANAGARI }, > { "ms", USCRIPT_LATIN }, > { "mt", USCRIPT_LATIN }, > + { "mvy", USCRIPT_ARABIC }, > { "my", USCRIPT_MYANMAR }, > { "myv", USCRIPT_CYRILLIC }, > + { "mzn", USCRIPT_ARABIC }, > { "na", USCRIPT_LATIN }, > { "nb", USCRIPT_LATIN }, > { "ne", USCRIPT_DEVANAGARI }, > @@ -309,10 +341,13 @@ UScriptCode localeToScriptCodeForFontSelection(const > String& locale) > { "pau", USCRIPT_LATIN }, > { "pl", USCRIPT_LATIN }, > { "pon", USCRIPT_LATIN }, > + { "prd", USCRIPT_ARABIC }, > + { "prs", USCRIPT_ARABIC }, > { "ps", USCRIPT_ARABIC }, > { "pt", USCRIPT_LATIN }, > { "qu", USCRIPT_LATIN }, > { "rm", USCRIPT_LATIN }, > + { "rmt", USCRIPT_ARABIC }, > { "rn", USCRIPT_LATIN }, > { "ro", USCRIPT_LATIN }, > { "ru", USCRIPT_CYRILLIC }, > @@ -321,11 +356,14 @@ UScriptCode localeToScriptCodeForFontSelection(const > String& locale) > { "sah", USCRIPT_CYRILLIC }, > { "sat", USCRIPT_LATIN }, > { "sd", USCRIPT_ARABIC }, > + { "sdh", USCRIPT_ARABIC }, > { "se", USCRIPT_LATIN }, > { "sg", USCRIPT_LATIN }, > + { "shi", USCRIPT_ARABIC }, > { "si", USCRIPT_SINHALA }, > { "sid", USCRIPT_LATIN }, > { "sk", USCRIPT_LATIN }, > + { "skr", USCRIPT_ARABIC }, > { "sl", USCRIPT_LATIN }, > { "sm", USCRIPT_LATIN }, > { "so", USCRIPT_LATIN }, > @@ -334,8 +372,11 @@ UScriptCode localeToScriptCodeForFontSelection(const > String& locale) > { "ss", USCRIPT_LATIN }, > { "st", USCRIPT_LATIN }, > { "su", USCRIPT_LATIN }, > + { "sus", USCRIPT_ARABIC }, > { "sv", USCRIPT_LATIN }, > { "sw", USCRIPT_LATIN }, > + { "swb", USCRIPT_ARABIC }, > + { "syr", USCRIPT_ARABIC }, > { "ta", USCRIPT_TAMIL }, > { "te", USCRIPT_TELUGU }, > { "tet", USCRIPT_LATIN }, > @@ -353,6 +394,7 @@ UScriptCode localeToScriptCodeForFontSelection(const > String& locale) > { "trv", USCRIPT_LATIN }, > { "ts", USCRIPT_LATIN }, > { "tt", USCRIPT_CYRILLIC }, > + { "ttt", USCRIPT_ARABIC }, > { "tvl", USCRIPT_LATIN }, > { "tw", USCRIPT_LATIN }, > { "ty", USCRIPT_LATIN }, > @@ -372,6 +414,7 @@ UScriptCode localeToScriptCodeForFontSelection(const > String& locale) > { "yap", USCRIPT_LATIN }, > { "yo", USCRIPT_LATIN }, > { "za", USCRIPT_LATIN }, > + { "zdj", USCRIPT_ARABIC }, > { "zh", USCRIPT_SIMPLIFIED_HAN }, > { "zh_hk", USCRIPT_TRADITIONAL_HAN }, > { "zh_tw", USCRIPT_TRADITIONAL_HAN }, > > > To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
lgtm
@Roozbeh: My fault, fixed and rechecked with source. PTAL
LGTM, thank you!
The CQ bit was checked by eae@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from behdad@google.com Link to the patchset: https://codereview.chromium.org/1008343002/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008343002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=192205 |
