Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1008333002: Move time constants to base::Time (Closed)

Created:
5 years, 9 months ago by qiankun
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, oshima+watch_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move time constants to base::Time BUG=412254 Committed: https://crrev.com/5bc0af3b3b3115d24077258ac7e079f454458fcb Cr-Commit-Position: refs/heads/master@{#320875}

Patch Set 1 #

Patch Set 2 : Time -> base::Time #

Total comments: 4

Patch Set 3 : fix comments#3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M base/time/time.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
qiankun
Do you think is this change necessary?
5 years, 9 months ago (2015-03-16 09:45:34 UTC) #2
Lei Zhang
https://codereview.chromium.org/1008333002/diff/20001/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/1008333002/diff/20001/base/time/time.h#newcode243 base/time/time.h:243: static const int64 kMicrosecondsPerDay = kMicrosecondsPerHour * 24; Since ...
5 years, 9 months ago (2015-03-16 21:11:49 UTC) #3
qiankun
https://codereview.chromium.org/1008333002/diff/20001/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/1008333002/diff/20001/base/time/time.h#newcode243 base/time/time.h:243: static const int64 kMicrosecondsPerDay = kMicrosecondsPerHour * 24; On ...
5 years, 9 months ago (2015-03-17 03:20:35 UTC) #4
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-17 04:52:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008333002/40001
5 years, 9 months ago (2015-03-17 04:54:53 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-17 06:53:02 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 06:53:46 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5bc0af3b3b3115d24077258ac7e079f454458fcb
Cr-Commit-Position: refs/heads/master@{#320875}

Powered by Google App Engine
This is Rietveld 408576698