Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1008323002: Land Recent QUIC Changes until 03/15/2015. (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, alyssar, Ian Swett
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0315
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes until 03/15/2015. Do not retransmit QUIC data for streams that have been reset. Protected by FLAGS_quic_do_not_retransmit_for_reset_streams. This is an attempt to reland cr/88179867 now that the underlying bug has been fixed. Includes tests which crashed on the old CL and pass now. Merge internal change: 88695223 https://codereview.chromium.org/1009243002/ Move QUIC reads to a more optimized reader. Guarded by FLAGS_quic_use_optimized_packet_reader. This is not enabled for the chromium's QUIC server yet. The new QuicPacketReader is optimized to spend less time in memset and uses a 16 packet receive buffer. Saves 1.09 % of CPU in memset alone according to profiling EndToEndTest. Merge internal change: 88573234 https://codereview.chromium.org/1008313002/ Rollback of merge internal change: 87346681. Chromium CL reviewed: https://codereview.chromium.org/968923005/ Chomium committed CL: "Land Recent QUIC Changes until 03/02/2015". https://codereview.chromium.org/968233004/ This CL was in M43 bit not in M42. It impacted last week's Dev release and all Canary released after 03/03/2015. *** Original change description *** Remove TCP and BBR's max congestion window. No practical change, because Chrome's receive window is the limiting factor. Adds kMaxReportedCwnd and kMaxReorderingForRtt as constants to replace the max CWND in classes that used to rely on max CWND. *** Merge internal change: 88545044 https://codereview.chromium.org/1003863006/ Make the SentPacketManager remove pending retransmissions for reset streams. No behavior change yet. That will be in a flag protected followup. Minor change to linked_hash_map's erase method to return an iterator pointing to the new location of the element that followed the last element erased by the function call (ala internal source code and std:: c++). Merge internal change: 88507368 https://codereview.chromium.org/1013583002/ Only changes comments. Replace "CID" with "connection id" in various comments in quic_connection_test.cc Merge internal change: 88463135 https://codereview.chromium.org/1013573002/ Provide a MockConnection constructor that takes connection_id, perspective, and is_secure as arguments. Used by the internal server testing code. Clarify debugging log message in quic_dispatcher.cc. Clarify debugging log message in quic_dispatcher.cc. Improve testing infrastructure. Merge internal change: 88461470 https://codereview.chromium.org/1008293002/ Add a kBYTE congestion option to QUIC to negotiate the TcpCubicBytesSender. Merge internal change: 88328620 https://codereview.chromium.org/1009203003/ Add support for the MIN1 connection option to TcpCubicBytesSender. This sender is currently unused. Allows TcpCubicBytesSender to have a min cwnd of 1 packet in bytes. Merge internal change: 88167032 https://codereview.chromium.org/1008283002/ R=rch@chromium.org Committed: https://crrev.com/fb3fa6c5773387e1fa71422ff24278a64eb0d2d6 Cr-Commit-Position: refs/heads/master@{#320819}

Patch Set 1 #

Patch Set 2 : Add quic_packet_reader to BUILD.gn to fix compiler errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+676 lines, -78 lines) Patch
M net/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/linked_hash_map.h View 1 chunk +13 lines, -8 lines 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender.cc View 8 chunks +17 lines, -7 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 3 chunks +6 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 5 chunks +22 lines, -14 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 6 chunks +69 lines, -5 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 8 chunks +116 lines, -11 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +5 lines, -6 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 2 chunks +23 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 4 chunks +47 lines, -3 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
A net/tools/quic/quic_packet_reader.h View 1 chunk +78 lines, -0 lines 0 comments Download
A net/tools/quic/quic_packet_reader.cc View 1 chunk +143 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server.cc View 1 4 chunks +38 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-16 04:11:30 UTC) #1
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-16 04:36:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008323002/1
5 years, 9 months ago (2015-03-16 06:13:41 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/52572)
5 years, 9 months ago (2015-03-16 06:54:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008323002/20001
5 years, 9 months ago (2015-03-16 18:09:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008323002/20001
5 years, 9 months ago (2015-03-16 21:16:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-16 22:10:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008323002/20001
5 years, 9 months ago (2015-03-16 22:14:36 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 23:05:04 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 23:05:38 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb3fa6c5773387e1fa71422ff24278a64eb0d2d6
Cr-Commit-Position: refs/heads/master@{#320819}

Powered by Google App Engine
This is Rietveld 408576698