Issue 1008313002: Move QUIC reads to a more optimized reader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1008313002: Move QUIC reads to a more optimized reader. (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@rollback_of_changelist_87346681_88545044

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move QUIC reads to a more optimized reader. Guarded by FLAGS_quic_use_optimized_packet_reader. This is not enabled for the chromium's QUIC server yet. The new QuicPacketReader is optimized to spend less time in memset and uses a 16 packet receive buffer. Saves 1.09 % of CPU in memset alone according to profiling EndToEndTest. Merge internal change: 88573234 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : Minor TODO comment fix #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+263 lines, -5 lines)			Patch
M	net/net.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	net/tools/quic/quic_packet_reader.h	View		1 chunk	+78 lines, -0 lines	0 comments	Download
A	net/tools/quic/quic_packet_reader.cc	View		1 chunk	+143 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_server.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_server.cc	View	1	4 chunks	+37 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages