Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1008303002: Only disable hotwording if the VoiceTrigger field trial is set to 'Disabled'. (Closed)

Created:
5 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, kcarattini
CC:
chromium-reviews, dbeam+watch-options_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, michaelpg+watch-options_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, rlp+watch_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only disable hotwording if the VoiceTrigger field trial is set to 'Disabled'. Also, delete the 'Experimental' field trial group since it was never used. BUG=465174 Committed: https://crrev.com/6b006fd3f1e00e4920ed22755edce6b9ce64f024 Cr-Commit-Position: refs/heads/master@{#320824}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change some EXPECTs to ASSERTs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -55 lines) Patch
M chrome/browser/search/hotword_service.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/search/hotword_service_unittest.cc View 1 18 chunks +33 lines, -41 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Anand Mistry (off Chromium)
5 years, 9 months ago (2015-03-16 03:01:02 UTC) #2
kcarattini
lgtm
5 years, 9 months ago (2015-03-16 03:24:21 UTC) #3
Anand Mistry (off Chromium)
thestig@chromium.org: For OWNERS.
5 years, 9 months ago (2015-03-16 03:30:25 UTC) #5
Lei Zhang
lgtm Drive by comment below. Feel free to address separately. https://codereview.chromium.org/1008303002/diff/1/chrome/browser/search/hotword_service_unittest.cc File chrome/browser/search/hotword_service_unittest.cc (right): https://codereview.chromium.org/1008303002/diff/1/chrome/browser/search/hotword_service_unittest.cc#newcode265 ...
5 years, 9 months ago (2015-03-16 21:48:30 UTC) #6
Anand Mistry (off Chromium)
https://codereview.chromium.org/1008303002/diff/1/chrome/browser/search/hotword_service_unittest.cc File chrome/browser/search/hotword_service_unittest.cc (right): https://codereview.chromium.org/1008303002/diff/1/chrome/browser/search/hotword_service_unittest.cc#newcode265 chrome/browser/search/hotword_service_unittest.cc:265: EXPECT_TRUE(hotword_service != NULL); On 2015/03/16 21:48:30, Lei Zhang wrote: ...
5 years, 9 months ago (2015-03-16 22:27:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008303002/20001
5 years, 9 months ago (2015-03-16 22:29:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 23:44:05 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 23:45:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b006fd3f1e00e4920ed22755edce6b9ce64f024
Cr-Commit-Position: refs/heads/master@{#320824}

Powered by Google App Engine
This is Rietveld 408576698