Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 1008293002: Provide a MockConnection constructor that takes connection_id, (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Add_a_kBYTE_congestion_option_88328620
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide a MockConnection constructor that takes connection_id, perspective, and is_secure as arguments. Used by the internal server testing code. Clarify debugging log message in quic_dispatcher.cc. Clarify debugging log message in quic_dispatcher.cc. Improve testing infrastructure. Merge internal change: 88461470 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M net/quic/quic_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-16 01:48:37 UTC) #1
Ryan Hamilton
5 years, 9 months ago (2015-03-16 03:16:21 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698