Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1008273003: Rename HotwordServiceFactory::IsHotwordHardwareAvailable() to IsAlwaysOnAvailable(). (Closed)

Created:
5 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, michaelpg+watch-options_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, rlp+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, chromium-apps-reviews_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename HotwordServiceFactory::IsHotwordHardwareAvailable() to IsAlwaysOnAvailable(). Two reasons: 1. This name is a better reflection of what this function does. 2. I want to introduce an IsHotwordHardwareAvailable() that actually returns whether hotword hardware is available. One that cannot be overridden with a flag and always returns the real value. Committed: https://crrev.com/c103d25c687705fbeb5c629a91ea732afebf2dec Cr-Commit-Position: refs/heads/master@{#320807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/extensions/component_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/hotword_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search/hotword_service_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search/hotword_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Anand Mistry (off Chromium)
5 years, 9 months ago (2015-03-16 03:28:49 UTC) #2
kcarattini
lgtm
5 years, 9 months ago (2015-03-16 03:42:25 UTC) #3
Anand Mistry (off Chromium)
jhawkins@chromium.org: For OWNERS.
5 years, 9 months ago (2015-03-16 03:47:30 UTC) #5
James Hawkins
lgtm
5 years, 9 months ago (2015-03-16 17:10:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008273003/1
5 years, 9 months ago (2015-03-16 22:29:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 22:33:00 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 22:33:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c103d25c687705fbeb5c629a91ea732afebf2dec
Cr-Commit-Position: refs/heads/master@{#320807}

Powered by Google App Engine
This is Rietveld 408576698