Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1008243003: Nuke NativeImageSkia -- new version. (Closed)

Created:
5 years, 9 months ago by Stephen White
Modified:
5 years, 9 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, dshwang, fs, dcheng, kouhei+svg_chromium.org, rwlbuis, krit, blink-reviews-html_chromium.org, Justin Novosad, danakj, dglazkov+blink, Rik, gavinp+loader_chromium.org, pdr+svgwatchlist_chromium.org, jbroman, Dominik Röttsches, pdr+graphicswatchlist_chromium.org, gyuyoung.kim_webkit.org, Nate Chapin, tyoshino+watch_chromium.org, blink-layers+watch_chromium.org, ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Nuke NativeImageSkia -- new version.

Patch Set 1 #

Patch Set 2 : Fix pasteboard #

Patch Set 3 : Fix BitmapImageTest #

Patch Set 4 : Fixes #

Patch Set 5 : Fix ImageBitmapTest in Release #

Patch Set 6 : Convert BitmapImage::createFrameAtIndex() to Skia-style #

Total comments: 2

Patch Set 7 : Fix logic errors; switch DeferredImageDecoder::createFrameAtIndex() to Skia-style #

Patch Set 8 : Add WARN_UNUSED_RETURN to Image::bitmapForCurrentFrame(); check return values. #

Patch Set 9 : Actually ignore unused result for Android gcc #

Patch Set 10 : Add more WARN_UNUSED_RETURN goodness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -471 lines) Patch
M Source/core/clipboard/Pasteboard.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/fetch/ImageResource.cpp View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/frame/ImageBitmap.cpp View 1 2 3 4 5 6 7 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/frame/ImageBitmapTest.cpp View 1 2 3 4 4 chunks +14 lines, -12 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/imagebitmap/ImageBitmapFactories.cpp View 1 2 3 4 5 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/svg/graphics/SVGImageForContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImageForContainer.cpp View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/DragImage.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/platform/DragImageTest.cpp View 1 2 3 4 5 6 7 8 9 9 chunks +16 lines, -16 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/exported/WebImageSkia.cpp View 1 2 3 4 chunks +7 lines, -12 lines 0 comments Download
M Source/platform/graphics/BitmapImage.h View 1 2 3 4 5 6 7 8 9 6 chunks +5 lines, -6 lines 0 comments Download
M Source/platform/graphics/BitmapImage.cpp View 1 2 3 4 5 6 10 chunks +52 lines, -31 lines 0 comments Download
M Source/platform/graphics/BitmapImageTest.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/graphics/BitmapPattern.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/graphics/BitmapPattern.cpp View 1 2 3 4 5 6 2 chunks +6 lines, -8 lines 0 comments Download
M Source/platform/graphics/BitmapPatternBase.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/DeferredImageDecoder.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/DeferredImageDecoder.cpp View 1 2 3 4 5 6 1 chunk +9 lines, -8 lines 0 comments Download
M Source/platform/graphics/DeferredImageDecoderTest.cpp View 1 2 3 4 5 6 9 chunks +36 lines, -27 lines 0 comments Download
M Source/platform/graphics/FrameData.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/graphics/FrameData.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/GraphicsContextTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M Source/platform/graphics/Image.h View 1 2 3 4 5 6 7 3 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/Image.cpp View 3 chunks +77 lines, -3 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/graphics/ImageBufferSurface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ImageLayerChromiumTest.cpp View 5 chunks +8 lines, -10 lines 0 comments Download
M Source/platform/graphics/ImageSource.h View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M Source/platform/graphics/ImageSource.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/StaticBitmapImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/gpu/WebGLImageConversion.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/platform/graphics/gpu/WebGLImageConversion.cpp View 1 2 3 4 5 6 7 3 chunks +16 lines, -16 lines 0 comments Download
D Source/platform/graphics/skia/NativeImageSkia.h View 1 chunk +0 lines, -96 lines 0 comments Download
D Source/platform/graphics/skia/NativeImageSkia.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
M Source/platform/image-decoders/ImageFrame.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/image-decoders/ImageFrame.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/DragClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebElement.cpp View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebImageDecoder.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Justin Novosad
https://codereview.chromium.org/1008243003/diff/100001/Source/platform/graphics/BitmapImage.h File Source/platform/graphics/BitmapImage.h (right): https://codereview.chromium.org/1008243003/diff/100001/Source/platform/graphics/BitmapImage.h#newcode87 Source/platform/graphics/BitmapImage.h:87: virtual bool bitmapForCurrentFrame(SkBitmap*) override; You should use the WARN_UNUSED_RETURN ...
5 years, 9 months ago (2015-03-16 15:16:58 UTC) #2
Stephen White
https://codereview.chromium.org/1008243003/diff/100001/Source/platform/graphics/BitmapImage.h File Source/platform/graphics/BitmapImage.h (right): https://codereview.chromium.org/1008243003/diff/100001/Source/platform/graphics/BitmapImage.h#newcode87 Source/platform/graphics/BitmapImage.h:87: virtual bool bitmapForCurrentFrame(SkBitmap*) override; On 2015/03/16 15:16:58, junov wrote: ...
5 years, 9 months ago (2015-03-16 15:41:11 UTC) #3
Stephen White
5 years, 9 months ago (2015-03-16 23:06:20 UTC) #4
Message was sent while issue was closed. 
Copied to https://codereview.chromium.org/1001703003/; closing.

Powered by Google App Engine
This is Rietveld 408576698