Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3795)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java

Issue 1008233004: Card unmasking prompt - crossfade progress overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
index b42b6c1c27198f19fabb40349011c0b25c3087b3..f241162bb907bc1b628af48d939035851505b12a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java
@@ -59,7 +59,7 @@ public class CardUnmaskPrompt
private final CheckBox mStoreLocallyCheckbox;
private final ImageView mStoreLocallyTooltipIcon;
private PopupWindow mStoreLocallyTooltipPopup;
- private final ViewGroup mMainContents;
+ private final ViewGroup mControlsContainer;
private final View mVerificationOverlay;
private final ProgressBar mVerificationProgressBar;
private final TextView mVerificationView;
@@ -109,7 +109,7 @@ public class CardUnmaskPrompt
mStoreLocallyCheckbox.setChecked(defaultToStoringLocally);
mStoreLocallyTooltipIcon = (ImageView) v.findViewById(R.id.store_locally_tooltip_icon);
mStoreLocallyTooltipIcon.setOnLongClickListener(this);
- mMainContents = (ViewGroup) v.findViewById(R.id.main_contents);
+ mControlsContainer = (ViewGroup) v.findViewById(R.id.controls_container);
mVerificationOverlay = v.findViewById(R.id.verification_overlay);
mVerificationProgressBar = (ProgressBar) v.findViewById(R.id.verification_progress_bar);
mVerificationView = (TextView) v.findViewById(R.id.verification_message);
@@ -295,12 +295,18 @@ public class CardUnmaskPrompt
*/
private void setOverlayVisibility(int visibility) {
mVerificationOverlay.setVisibility(visibility);
+ mControlsContainer.setAlpha(1f);
boolean contentsShowing = visibility == View.GONE;
- mMainContents.setAlpha(contentsShowing ? 1.0f : 0.15f);
- ViewCompat.setImportantForAccessibility(mMainContents,
+ if (!contentsShowing) {
+ int duration = 250;
newt (away) 2015/03/24 20:43:47 durationMs
Evan Stade 2015/03/24 21:47:08 Done.
+ mVerificationOverlay.setAlpha(0f);
+ mVerificationOverlay.animate().alpha(1f).setDuration(duration);
+ mControlsContainer.animate().alpha(0f).setDuration(duration);
+ }
+ ViewCompat.setImportantForAccessibility(mControlsContainer,
contentsShowing ? View.IMPORTANT_FOR_ACCESSIBILITY_AUTO
: View.IMPORTANT_FOR_ACCESSIBILITY_NO_HIDE_DESCENDANTS);
- mMainContents.setDescendantFocusability(
+ mControlsContainer.setDescendantFocusability(
contentsShowing ? ViewGroup.FOCUS_BEFORE_DESCENDANTS
: ViewGroup.FOCUS_BLOCK_DESCENDANTS);
}

Powered by Google App Engine
This is Rietveld 408576698