Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1008233004: Card unmasking prompt - crossfade progress overlay (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Card unmasking prompt - crossfade progress overlay also, only cover the controls and not the instructions also various tweaks to colors and font sizes and layout as per latest mocks. BUG=none Committed: https://crrev.com/c88701ac137962a7fccff0993f9b9a5c509580ce Cr-Commit-Position: refs/heads/master@{#322081}

Patch Set 1 #

Total comments: 6

Patch Set 2 : newt review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -25 lines) Patch
M chrome/android/java/res/layout/autofill_card_unmask_prompt.xml View 1 5 chunks +29 lines, -19 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/CardUnmaskPrompt.java View 1 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Evan Stade
5 years, 9 months ago (2015-03-24 19:35:40 UTC) #2
newt (away)
https://codereview.chromium.org/1008233004/diff/1/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml File chrome/android/java/res/layout/autofill_card_unmask_prompt.xml (right): https://codereview.chromium.org/1008233004/diff/1/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml#newcode33 chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:33: android:background="@color/input_underline_error_color" Is the whole background red now? How does ...
5 years, 9 months ago (2015-03-24 20:43:47 UTC) #3
Evan Stade
https://codereview.chromium.org/1008233004/diff/1/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml File chrome/android/java/res/layout/autofill_card_unmask_prompt.xml (right): https://codereview.chromium.org/1008233004/diff/1/chrome/android/java/res/layout/autofill_card_unmask_prompt.xml#newcode33 chrome/android/java/res/layout/autofill_card_unmask_prompt.xml:33: android:background="@color/input_underline_error_color" On 2015/03/24 20:43:47, newt wrote: > Is the ...
5 years, 9 months ago (2015-03-24 21:47:08 UTC) #4
newt (away)
lgtm
5 years, 9 months ago (2015-03-24 21:53:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008233004/20001
5 years, 9 months ago (2015-03-24 21:54:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 22:30:18 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 22:31:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c88701ac137962a7fccff0993f9b9a5c509580ce
Cr-Commit-Position: refs/heads/master@{#322081}

Powered by Google App Engine
This is Rietveld 408576698