Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1008233002: Add a test for a simulated click on a link on tapping of gesture. (Closed)

Created:
5 years, 9 months ago by Miyoung Shin
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for a simulated click on a link on tapping of gesture. When tapping of gesture with the Ctrl key, the click is simulated. The test checks if the new tab is opened on the background. BUG=464718 R=jochen@chromium.org TEST=PopupBlockerBrowserTest.TapGestureWithCtrlKey Committed: https://crrev.com/8143cbe34dd460c28f4b1996f563c9bad0a0e6ec Cr-Commit-Position: refs/heads/master@{#321157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/test/data/popup_blocker/popup-simulated-click-on-anchor2.html View 1 chunk +13 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Miyoung Shin
PTAL. We can land this after landing the patch at http://crrev.com/1010613002.
5 years, 9 months ago (2015-03-15 16:12:14 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-18 15:23:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008233002/1
5 years, 9 months ago (2015-03-18 16:17:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 17:26:17 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 17:27:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8143cbe34dd460c28f4b1996f563c9bad0a0e6ec
Cr-Commit-Position: refs/heads/master@{#321157}

Powered by Google App Engine
This is Rietveld 408576698