Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 100823015: Cast: move net->transport (Closed)

Created:
7 years ago by mikhal1
Modified:
6 years, 12 months ago
Reviewers:
pwestin
CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Cast: move net->transport - Moving files to the transport folder. - Adding transport namespace. - Consolidating all gyp's into cast_transport.gyp. - Misc clean up This cl should be patched on top of https://codereview.chromium.org/102413014/ BUG=327482 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242557

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 10

Patch Set 3 : fixing order #

Patch Set 4 : fixing order #

Patch Set 5 : rebase #

Patch Set 6 : rebase and clean up #

Patch Set 7 : Updating transport callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -3136 lines) Patch
M media/cast/README View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/audio_receiver/audio_receiver.h View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
M media/cast/audio_receiver/audio_receiver.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M media/cast/audio_receiver/audio_receiver_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/cast/audio_sender/audio_sender.h View 1 2 3 4 4 chunks +3 lines, -4 lines 0 comments Download
M media/cast/audio_sender/audio_sender.cc View 1 2 3 4 2 chunks +8 lines, -7 lines 0 comments Download
M media/cast/audio_sender/audio_sender.gypi View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/audio_sender/audio_sender_unittest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/cast.gyp View 1 2 3 4 5 5 chunks +10 lines, -10 lines 0 comments Download
M media/cast/cast_receiver.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/cast/cast_receiver_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/cast_sender.gyp View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M media/cast/cast_sender_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/framer/framer.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D media/cast/net/cast_net_defines.h View 1 2 3 4 1 chunk +0 lines, -124 lines 0 comments Download
D media/cast/net/cast_net_sender.h View 1 2 3 4 1 chunk +0 lines, -72 lines 0 comments Download
D media/cast/net/frame_id_wrap_helper_test.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D media/cast/net/pacing/mock_paced_packet_sender.h View 1 chunk +0 lines, -27 lines 0 comments Download
D media/cast/net/pacing/mock_paced_packet_sender.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D media/cast/net/pacing/paced_sender.h View 1 2 3 4 1 chunk +0 lines, -84 lines 0 comments Download
D media/cast/net/pacing/paced_sender.cc View 1 2 3 4 1 chunk +0 lines, -151 lines 0 comments Download
D media/cast/net/pacing/paced_sender.gyp View 1 chunk +0 lines, -22 lines 0 comments Download
D media/cast/net/pacing/paced_sender_unittest.cc View 1 chunk +0 lines, -257 lines 0 comments Download
D media/cast/net/rtcp/rtcp_builder.h View 1 2 3 4 1 chunk +0 lines, -78 lines 0 comments Download
D media/cast/net/rtcp/rtcp_builder.cc View 1 2 3 4 1 chunk +0 lines, -265 lines 0 comments Download
D media/cast/net/rtcp/rtcp_builder_unittest.cc View 1 2 3 4 1 chunk +0 lines, -208 lines 0 comments Download
D media/cast/net/rtp_sender/mock_rtp_sender.h View 1 chunk +0 lines, -34 lines 0 comments Download
D media/cast/net/rtp_sender/packet_storage/packet_storage.h View 1 chunk +0 lines, -55 lines 0 comments Download
D media/cast/net/rtp_sender/packet_storage/packet_storage.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D media/cast/net/rtp_sender/packet_storage/packet_storage.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
D media/cast/net/rtp_sender/packet_storage/packet_storage_unittest.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D media/cast/net/rtp_sender/rtp_packetizer/rtp_packetizer.h View 1 chunk +0 lines, -73 lines 0 comments Download
D media/cast/net/rtp_sender/rtp_packetizer/rtp_packetizer.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D media/cast/net/rtp_sender/rtp_packetizer/rtp_packetizer.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D media/cast/net/rtp_sender/rtp_packetizer/rtp_packetizer_config.h View 1 chunk +0 lines, -39 lines 0 comments Download
D media/cast/net/rtp_sender/rtp_packetizer/rtp_packetizer_config.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D media/cast/net/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D media/cast/net/rtp_sender/rtp_packetizer/test/rtp_header_parser.h View 1 chunk +0 lines, -60 lines 0 comments Download
D media/cast/net/rtp_sender/rtp_packetizer/test/rtp_header_parser.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D media/cast/net/rtp_sender/rtp_sender.h View 1 chunk +0 lines, -66 lines 0 comments Download
D media/cast/net/rtp_sender/rtp_sender.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D media/cast/net/rtp_sender/rtp_sender.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D media/cast/net/transport/transport.h View 1 2 3 4 1 chunk +0 lines, -52 lines 0 comments Download
D media/cast/net/transport/transport.cc View 1 2 3 4 1 chunk +0 lines, -195 lines 0 comments Download
D media/cast/net/transport/transport.gyp View 1 2 3 4 1 chunk +0 lines, -22 lines 0 comments Download
M media/cast/rtcp/mock_rtcp_receiver_feedback.h View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download
M media/cast/rtcp/rtcp.h View 1 2 3 4 5 chunks +8 lines, -5 lines 0 comments Download
M media/cast/rtcp/rtcp.cc View 1 2 3 4 10 chunks +14 lines, -13 lines 0 comments Download
M media/cast/rtcp/rtcp.gyp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/rtcp/rtcp_defines.h View 1 2 3 4 2 chunks +1 line, -9 lines 0 comments Download
M media/cast/rtcp/rtcp_receiver.h View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M media/cast/rtcp/rtcp_receiver.cc View 1 2 3 4 5 chunks +12 lines, -11 lines 0 comments Download
M media/cast/rtcp/rtcp_receiver_unittest.cc View 1 2 3 4 8 chunks +15 lines, -15 lines 0 comments Download
M media/cast/rtcp/rtcp_sender.h View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M media/cast/rtcp/rtcp_sender.cc View 1 2 3 4 5 chunks +6 lines, -6 lines 0 comments Download
M media/cast/rtcp/rtcp_sender_unittest.cc View 1 2 3 4 9 chunks +10 lines, -9 lines 0 comments Download
M media/cast/rtcp/rtcp_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/rtp_parser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/rtp_parser.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/rtp_receiver/rtp_receiver.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/rtp_receiver/rtp_receiver_defines.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/test/receiver.cc View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M media/cast/test/sender.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
A media/cast/transport/cast_transport.gyp View 1 2 3 4 5 1 chunk +39 lines, -0 lines 0 comments Download
A + media/cast/transport/cast_transport_defines.h View 1 2 3 4 3 chunks +13 lines, -3 lines 0 comments Download
A + media/cast/transport/cast_transport_sender.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + media/cast/transport/frame_id_wrap_helper_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + media/cast/transport/pacing/mock_paced_packet_sender.h View 2 chunks +6 lines, -4 lines 0 comments Download
A + media/cast/transport/pacing/mock_paced_packet_sender.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + media/cast/transport/pacing/paced_sender.h View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
A + media/cast/transport/pacing/paced_sender.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
A + media/cast/transport/pacing/paced_sender_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
A + media/cast/transport/rtcp/rtcp_builder.h View 1 2 3 4 2 chunks +8 lines, -7 lines 0 comments Download
A + media/cast/transport/rtcp/rtcp_builder.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
A + media/cast/transport/rtcp/rtcp_builder_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + media/cast/transport/rtp_sender/mock_rtp_sender.h View 2 chunks +6 lines, -4 lines 0 comments Download
A + media/cast/transport/rtp_sender/packet_storage/packet_storage.h View 4 chunks +6 lines, -4 lines 0 comments Download
A + media/cast/transport/rtp_sender/packet_storage/packet_storage.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
A + media/cast/transport/rtp_sender/packet_storage/packet_storage_unittest.cc View 3 chunks +3 lines, -1 line 0 comments Download
A + media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.h View 2 chunks +29 lines, -5 lines 0 comments Download
A + media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.cc View 1 2 3 4 2 chunks +18 lines, -3 lines 0 comments Download
A + media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
A + media/cast/transport/rtp_sender/rtp_packetizer/test/rtp_header_parser.h View 1 2 chunks +8 lines, -6 lines 0 comments Download
A + media/cast/transport/rtp_sender/rtp_packetizer/test/rtp_header_parser.cc View 1 3 chunks +3 lines, -1 line 0 comments Download
A + media/cast/transport/rtp_sender/rtp_sender.h View 1 2 3 4 3 chunks +8 lines, -7 lines 0 comments Download
A + media/cast/transport/rtp_sender/rtp_sender.cc View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
A + media/cast/transport/transport/transport.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
A + media/cast/transport/transport/transport.cc View 1 2 3 4 5 6 4 chunks +15 lines, -5 lines 0 comments Download
M media/cast/video_receiver/video_receiver.h View 1 2 3 4 5 2 chunks +1 line, -3 lines 0 comments Download
M media/cast/video_receiver/video_receiver.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M media/cast/video_receiver/video_receiver_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/cast/video_sender/video_sender.h View 1 2 3 4 4 chunks +3 lines, -4 lines 0 comments Download
M media/cast/video_sender/video_sender.cc View 1 2 3 4 4 chunks +18 lines, -13 lines 0 comments Download
M media/cast/video_sender/video_sender.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M media/cast/video_sender/video_sender_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mikhal1
Please review, -Mikhal
7 years ago (2013-12-19 18:33:29 UTC) #1
pwestin
Please fix the order based on the new folder name. Issue in most gyp files ...
7 years ago (2013-12-19 18:58:04 UTC) #2
mikhal1
PTAL https://codereview.chromium.org/100823015/diff/40001/media/cast/cast.gyp File media/cast/cast.gyp (right): https://codereview.chromium.org/100823015/diff/40001/media/cast/cast.gyp#newcode72 media/cast/cast.gyp:72: 'transport/pacing/paced_sender_unittest.cc', On 2013/12/19 18:58:05, pwestin wrote: > move ...
7 years ago (2013-12-19 19:32:08 UTC) #3
pwestin
lgtm
7 years ago (2013-12-19 20:45:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/100823015/130098
7 years ago (2013-12-20 18:14:03 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=103001
7 years ago (2013-12-20 19:19:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/100823015/680001
7 years ago (2013-12-20 19:50:04 UTC) #7
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=136669
7 years ago (2013-12-21 01:01:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/100823015/940001
6 years, 12 months ago (2013-12-26 19:17:00 UTC) #9
commit-bot: I haz the power
6 years, 12 months ago (2013-12-26 21:45:31 UTC) #10
Message was sent while issue was closed. 
Change committed as 242557

Powered by Google App Engine
This is Rietveld 408576698