Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 100823012: Show delete button in input[type=search] only if the field is editable and focused/hovered. (Closed)

Created:
7 years ago by tkent
Modified:
7 years ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Visibility:
Public.

Description

Show delete button in input[type=search] only if the field is editable and focused/hovered. Also, we show/hide the button with CSS opacity property instead of CSS visibility property when the value emptiness is changed. This helps Web authors to add CSS transition. BUG=325496 TEST=automated. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163512

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Update pointer-events #

Patch Set 3 : Update touchadjustment/search-cancel.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +14 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/search-cancel-button-style-sharing.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/search/search-appearance-basic.html View 2 chunks +11 lines, -1 line 0 comments Download
M LayoutTests/touchadjustment/search-cancel.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/html.css View 1 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/html/forms/SearchInputType.cpp View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tkent
7 years ago (2013-12-09 04:03:43 UTC) #1
keishi
https://codereview.chromium.org/100823012/diff/80001/Source/core/css/html.css File Source/core/css/html.css (right): https://codereview.chromium.org/100823012/diff/80001/Source/core/css/html.css#newcode459 Source/core/css/html.css:459: opacity: 0; I think this should be "visibility: hidden". ...
7 years ago (2013-12-09 06:24:49 UTC) #2
tkent
https://codereview.chromium.org/100823012/diff/80001/Source/core/css/html.css File Source/core/css/html.css (right): https://codereview.chromium.org/100823012/diff/80001/Source/core/css/html.css#newcode459 Source/core/css/html.css:459: opacity: 0; On 2013/12/09 06:24:49, keishi1 wrote: > I ...
7 years ago (2013-12-09 06:45:18 UTC) #3
keishi
On 2013/12/09 06:45:18, tkent wrote: > https://codereview.chromium.org/100823012/diff/80001/Source/core/css/html.css > File Source/core/css/html.css (right): > > https://codereview.chromium.org/100823012/diff/80001/Source/core/css/html.css#newcode459 > ...
7 years ago (2013-12-09 07:51:54 UTC) #4
tkent
On 2013/12/09 07:51:54, keishi1 wrote: > I think most of the time, we use the ...
7 years ago (2013-12-09 08:50:07 UTC) #5
keishi
lgtm
7 years ago (2013-12-10 07:46:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/100823012/120001
7 years ago (2013-12-10 07:48:32 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-10 07:54:31 UTC) #8
Message was sent while issue was closed.
Change committed as 163512

Powered by Google App Engine
This is Rietveld 408576698