base/debug/trace_event_impl.cc - Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/trace_event_impl.cc

Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Nits Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/trace_event_impl.cc

diff --git a/base/debug/trace_event_impl.cc b/base/debug/trace_event_impl.cc

index aebaf10a45253f4b2989cc819918dec07e58a843..b13e30714b61d8e4c17888c40d0c68eac4294468 100644

--- a/base/debug/trace_event_impl.cc

+++ b/base/debug/trace_event_impl.cc

@@ -650,7 +650,7 @@ void TraceEvent::AppendValueAsJSON(unsigned char type,

break;

case TRACE_VALUE_TYPE_STRING:

case TRACE_VALUE_TYPE_COPY_STRING:

- JsonDoubleQuote(value.as_string ? value.as_string : "NULL", true, out);

+ EscapeJSONString(value.as_string ? value.as_string : "NULL", true, out);

break;

default:

NOTREACHED() << "Don't know how to print this value";

« no previous file with comments | « no previous file | base/json/json_value_serializer_unittest.cc » ('j') | base/json/string_escape.h » ('J')