chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc - Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

Issue 100823007: Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix ChromeOS page encodings Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log_unittest.cc ('k') | chrome/browser/resources/chromeos/login/login.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

diff --git a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

index 58982a27cbe6927f6d504528674a25f0f18006a7..841ace27f8a966cfcde142de42b01243b7a79976 100644

--- a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

+++ b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

@@ -34,12 +34,10 @@ class NativeMessagingHostManifestTest : public ::testing::Test {

bool WriteManifest(const std::string& name,

const std::string& path,

const std::string& origin) {

- std::string escaped_path;

- base::JsonDoubleQuote(path, false, &escaped_path);

return WriteManifest("{"

" \"name\": \"" + name + "\","

" \"description\": \"Native Messaging Test\","

- " \"path\": \"" + escaped_path + "\","

+ " \"path\": " + base::GetQuotedJSONString(path) + ","

" \"type\": \"stdio\","

" \"allowed_origins\": ["

" \"" + origin + "\""