Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

chrome/browser/search/iframe_source.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search/iframe_source.h"
 
 #include "base/json/string_escape.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
@@ skipping 70 matching lines @@
     int render_process_id,
     int render_view_id,
     const content::URLDataSource::GotDataCallback& callback) {
   std::string origin;
   if (!GetOrigin(render_process_id, render_view_id, &origin)) {
     callback.Run(NULL);
     return;
   }
 
   std::string js_escaped_origin;
-  base::JsonDoubleQuote(origin, false, &js_escaped_origin);
+  base::EscapeJSONString(origin, false, &js_escaped_origin);

[Mark Mentovai, 2013/12/06 15:35:12]

Here is one place I will ask that question.

In fact, if you take my suggestion, you might get a compiler warning about
js_escaped_origin being unused. Good point, compiler! It IS unused. We don’t
need this EscapeJSONString at all.

[Robert Sesek, 2013/12/09 19:52:09]

Done.

   base::StringPiece template_js =
       ResourceBundle::GetSharedInstance().GetRawDataResource(resource_id);
   std::string response(template_js.as_string());
   ReplaceFirstSubstringAfterOffset(&response, 0, "{{ORIGIN}}", origin);
   callback.Run(base::RefCountedString::TakeString(&response));
 }