Move SkPaint mangement for 2D canvas into CanvasRenderingContext2DState

Source/platform/graphics/GraphicsTypes.h

 /*
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 55 matching lines @@
     CompositeDestinationIn,
     CompositeDestinationOut,
     CompositeDestinationAtop,
     CompositeXOR,
     CompositePlusLighter
 };
 
 enum ShadowMode {
     DrawShadowAndForeground,
     DrawShadowOnly,
+    DrawForegroundOnly
+};
+
+enum CanvasPaintType {

[Stephen White, 2015/03/19 20:35:17]

Could this (and the CanvasShadowStrategy below) be in
CanvasRenderingContext2DState?

[Justin Novosad, 2015/03/19 21:03:36]

They could...

These enums are used in the declaration of
CanvasRenderingContext2D::fullCanvasCompositedDraw
If I move them to CanvasRenderingContext2DState.h, that would add a new include
dependency. Currently, CanvasRenderingContext2DState only needs to be forward
declared in CanvasRenderingContext2D.h

WDYT?

[Stephen White, 2015/03/19 22:37:26]

I don't mind the dependency. I think keeping canvas-specific stuff localized to
canvas headers is a nice property.

+    FillPaintType,
+    StrokePaintType,
+};
+
+enum CanvasShadowStrategy {
+    DrawLooperShadowStrategy,
+    ImageFilterShadowStrategy,
 };
 
 enum AntiAliasingMode {
     NotAntiAliased,
     AntiAliased
 };
 
 enum GradientSpreadMethod {
     SpreadMethodPad,
     SpreadMethodReflect,
@@ skipping 47 matching lines @@
 
 PLATFORM_EXPORT String textAlignName(TextAlign);
 PLATFORM_EXPORT bool parseTextAlign(const String&, TextAlign&);
 
 PLATFORM_EXPORT String textBaselineName(TextBaseline);
 PLATFORM_EXPORT bool parseTextBaseline(const String&, TextBaseline&);
 
 } // namespace blink
 
 #endif