Issue 100813002: Remove timeout behavior from Windows serial I/O

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100813002: Remove timeout behavior from Windows serial I/O (Closed)

Created:
7 years ago by Ken Rockot(use gerrit already)

Modified:
7 years ago

Reviewers:
rpaquay

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove timeout behavior from Windows serial I/O Reads on the Windows impl of SerialConnection were erroneously set to wait for up to 10ms before completing with less than the requested amount of data. They will now complete immediately with any available data, without waiting. BUG=324886 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238367

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
		chrome/browser/extensions/api/serial/serial_connection_win.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rpaquay

On 2013/12/03 01:29:23, Ken Rockot wrote: > Please have a look. lgtm

7 years ago (2013-12-03 02:35:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/100813002/1

7 years ago (2013-12-03 02:42:25 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195918

7 years ago (2013-12-03 06:08:06 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/100813002/1

7 years ago (2013-12-03 08:16:10 UTC) #5

Message was sent while issue was closed.

Change committed as 238367

Expand Messages | Collapse Messages