Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: sync/syncable/mutable_entry.cc

Issue 1008103002: Sync: Avoid 3 passes over SyncDarta DB when loading the directory from the disk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR feedback. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/syncable/invalid_directory_backing_store.cc ('k') | sync/syncable/on_disk_directory_backing_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/syncable/mutable_entry.cc
diff --git a/sync/syncable/mutable_entry.cc b/sync/syncable/mutable_entry.cc
index 89c8b052f85e25b509657d2e00677173d1132d1a..d627cf4a6a45894d4667ae9918eebee8cd71cbaf 100644
--- a/sync/syncable/mutable_entry.cc
+++ b/sync/syncable/mutable_entry.cc
@@ -184,9 +184,9 @@ void MutableEntry::PutIsDel(bool value) {
// - Ensure that the item is never committed to the server.
// - Allow any items with the same UNIQUE_CLIENT_TAG created on other
// clients to override this entry.
- // - Let us delete this entry permanently through
- // DirectoryBackingStore::DropDeletedEntries() when we next restart sync.
- // This will save memory and avoid crbug.com/125381.
+ // - Let us delete this entry permanently when we next restart sync - see
+ // DirectoryBackingStore::SafeToPurgeOnLoading.
+ // This will avoid crbug.com/125381.
// Note: do not unset IsUnsynced if the syncer is in the middle of
// attempting to commit this entity.
if (!GetId().ServerKnows() && !GetSyncing()) {
« no previous file with comments | « sync/syncable/invalid_directory_backing_store.cc ('k') | sync/syncable/on_disk_directory_backing_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698