sync/syncable/in_memory_directory_backing_store.h - Issue 1008103002: Sync: Avoid 3 passes over SyncDarta DB when loading the directory from the disk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/in_memory_directory_backing_store.h

Issue 1008103002: Sync: Avoid 3 passes over SyncDarta DB when loading the directory from the disk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/syncable/in_memory_directory_backing_store.h

diff --git a/sync/syncable/in_memory_directory_backing_store.h b/sync/syncable/in_memory_directory_backing_store.h

index 0a0f9baa5ac7b7eb782d541f05309ec518436128..d22e65fc53eb09866bdcb19e33679916de174926 100644

--- a/sync/syncable/in_memory_directory_backing_store.h

+++ b/sync/syncable/in_memory_directory_backing_store.h

@@ -26,6 +26,7 @@ class SYNC_EXPORT_PRIVATE InMemoryDirectoryBackingStore

explicit InMemoryDirectoryBackingStore(const std::string& dir_name);

DirOpenResult Load(Directory::MetahandlesMap* handles_map,

JournalIndex* delete_journals,

+ MetahandleSet* metahandles_to_purge,

Directory::KernelLoadInfo* kernel_load_info) override;

void request_consistent_cache_guid() {

« no previous file with comments | « sync/syncable/directory_unittest.cc ('k') | sync/syncable/in_memory_directory_backing_store.cc » ('j') | no next file with comments »