Issue 1008083003: Oilpan: Build fix after r192009

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1008083003: Oilpan: Build fix after r192009 (Closed)

Created:
5 years, 9 months ago by haraken

Modified:
5 years, 9 months ago

Reviewers:
oilpan-reviews, sof

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Build fix after r192009 TBR=sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192016

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	Source/core/inspector/InspectorHighlight.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

haraken

Committed patchset #2 (id:20001) manually as 192016 (presubmit successful).

5 years, 9 months ago (2015-03-17 15:42:16 UTC) #3

sof

5 years, 9 months ago (2015-03-17 15:44:52 UTC) #4

Message was sent while issue was closed.

thanks, lgtm.

An alternative is to pull InspectorHighlight off the heap; it has a short
lifetime & no traceable refs.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages