Adding Test Fixture for initial test cases for the App Remoting Test Driver. Also includes the pub…

remoting/test/remote_application_data.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_TEST_REMOTE_APPLICATION_DATA_H_
+#define REMOTING_TEST_REMOTE_APPLICATION_DATA_H_

[Wez, 2015/03/16 22:19:10]

nit: Make the filename & guard macro consistent with the struct name, below.

[joedow, 2015/03/18 20:13:09]

Done.

+
+#include <map>
+#include <string>
+#include <vector>
+
+namespace remoting {
+namespace test {
+
+const char kHostProcessWindowTitle[] = "Host Process";
+
+// Container for application specific information.
+struct ApplicationInfo {
+  ApplicationInfo(const std::string& app_id,
+                  const std::string& window_name)
+      : application_id(app_id), main_window_name(window_name) {}
+
+  std::string application_id;
+  std::string main_window_name;
+};
+
+// Returns a vector of the supported remote application names.
+const std::vector<std::string>& GetRemoteApplicationNames();

[Wez, 2015/03/16 22:19:10]

It's confusing that you refer to this as the "application name", "window name"
or "main window name" in different places.

As a result it's not clear whether this function returns actual application
names, application Ids, the names of all application windows, or the names only
of each application's "main" window.

[joedow, 2015/03/18 20:13:09]

Done.

+
+// Returns a map with remote application info indexed by application name.
+const std::map<std::string, ApplicationInfo>& GetRemoteApplicationInfoMap();

[Wez, 2015/03/16 22:19:10]

Again, it's not clear what the "name" is in this index, versus Id, window name,
etc.

[joedow, 2015/03/18 20:13:09]

Done.

+
+}  // namespace test
+}  // namespace remoting
+
+#endif  // REMOTING_TEST_REMOTE_APPLICATION_DATA_H_