Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: Source/core/paint/ImagePainter.cpp

Issue 1008043002: [S.P.] Don't draw frames of animated images that are offscreen. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/layout/LayoutObject.cpp ('k') | Source/platform/graphics/PaintInvalidationReason.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/paint/ImagePainter.h" 6 #include "core/paint/ImagePainter.h"
7 7
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/dom/Element.h" 9 #include "core/dom/Element.h"
10 #include "core/editing/FrameSelection.h" 10 #include "core/editing/FrameSelection.h"
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 if (!m_layoutImage.imageResource()->hasImage() || m_layoutImage.imageResourc e()->errorOccurred()) 120 if (!m_layoutImage.imageResource()->hasImage() || m_layoutImage.imageResourc e()->errorOccurred())
121 return; // FIXME: should we just ASSERT these conditions? (audit all cal lers). 121 return; // FIXME: should we just ASSERT these conditions? (audit all cal lers).
122 122
123 IntRect alignedRect = pixelSnappedIntRect(rect); 123 IntRect alignedRect = pixelSnappedIntRect(rect);
124 if (alignedRect.width() <= 0 || alignedRect.height() <= 0) 124 if (alignedRect.width() <= 0 || alignedRect.height() <= 0)
125 return; 125 return;
126 126
127 RefPtr<Image> image = m_layoutImage.imageResource()->image(alignedRect.width (), alignedRect.height()); 127 RefPtr<Image> image = m_layoutImage.imageResource()->image(alignedRect.width (), alignedRect.height());
128 if (!image || image->isNull()) 128 if (!image || image->isNull())
129 return; 129 return;
130 130 fprintf(stderr, "painting image\n");
Xianzhu 2015/03/19 22:14:22 Remove.
chrishtr 2015/03/19 22:15:16 Good catch. Fixed.
131 // FIXME: why is interpolation quality selection not included in the Instrum entation reported cost of drawing an image? 131 // FIXME: why is interpolation quality selection not included in the Instrum entation reported cost of drawing an image?
132 InterpolationQuality interpolationQuality = BoxPainter::chooseInterpolationQ uality(m_layoutImage, context, image.get(), image.get(), LayoutSize(alignedRect. size())); 132 InterpolationQuality interpolationQuality = BoxPainter::chooseInterpolationQ uality(m_layoutImage, context, image.get(), image.get(), LayoutSize(alignedRect. size()));
133 133
134 TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "PaintImage", " data", InspectorPaintImageEvent::data(m_layoutImage)); 134 TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "PaintImage", " data", InspectorPaintImageEvent::data(m_layoutImage));
135 135
136 InterpolationQuality previousInterpolationQuality = context->imageInterpolat ionQuality(); 136 InterpolationQuality previousInterpolationQuality = context->imageInterpolat ionQuality();
137 context->setImageInterpolationQuality(interpolationQuality); 137 context->setImageInterpolationQuality(interpolationQuality);
138 context->drawImage(image.get(), alignedRect, SkXfermode::kSrcOver_Mode, m_la youtImage.shouldRespectImageOrientation()); 138 context->drawImage(image.get(), alignedRect, SkXfermode::kSrcOver_Mode, m_la youtImage.shouldRespectImageOrientation());
139 context->setImageInterpolationQuality(previousInterpolationQuality); 139 context->setImageInterpolationQuality(previousInterpolationQuality);
140 } 140 }
141 141
142 } // namespace blink 142 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutObject.cpp ('k') | Source/platform/graphics/PaintInvalidationReason.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698