Changed maxInputCount for exact inputCount

Changed maxInputCount for exact inputCount

Processing still had issue when the number of inputs was 0, so I changed my previous fix from a maximum input count to an exact input count. -1 is used when the input count isn't fixed (but still has to be a non-negative number).

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=12492

[sugoi, 2013-12-03 16:10:21]

https://codereview.chromium.org/100803004/diff/1/src/animator/SkScript.cpp
File src/animator/SkScript.cpp (left):

https://codereview.chromium.org/100803004/diff/1/src/animator/SkScript.cpp#ol...
src/animator/SkScript.cpp:1538: SkASSERT(0); // must call through instance
version instead of static version
I had a minor issue here when I replaced SkASSERT by something noop for local
tests, which was easily fixed by adding brackets, so I left them in this cl,
since it doesn't hurt.

[Stephen White, 2013-12-03 16:22:35]

https://codereview.chromium.org/100803004/diff/1/include/core/SkImageFilter.h
File include/core/SkImageFilter.h (left):

https://codereview.chromium.org/100803004/diff/1/include/core/SkImageFilter.h...
include/core/SkImageFilter.h:159: explicit SkImageFilter(int maxInputCount,
SkFlattenableReadBuffer& rb);
Please document the -1 special case here.

[sugoi, 2013-12-03 16:30:52]

https://codereview.chromium.org/100803004/diff/1/include/core/SkImageFilter.h
File include/core/SkImageFilter.h (left):

https://codereview.chromium.org/100803004/diff/1/include/core/SkImageFilter.h...
include/core/SkImageFilter.h:159: explicit SkImageFilter(int maxInputCount,
SkFlattenableReadBuffer& rb);
On 2013/12/03 16:22:36, Stephen White wrote:
> Please document the -1 special case here.

Done.

[Stephen White, 2013-12-03 18:54:28]

https://codereview.chromium.org/100803004/diff/20001/include/core/SkImageFilt...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/100803004/diff/20001/include/core/SkImageFilt...
include/core/SkImageFilter.h:159: /**
Ubernit: the other C-style comments in this file use two spaces between the star
and the comment. (I swear I don't have OCD.)

[sugoi, 2013-12-03 18:59:36]

https://codereview.chromium.org/100803004/diff/20001/include/core/SkImageFilt...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/100803004/diff/20001/include/core/SkImageFilt...
include/core/SkImageFilter.h:159: /**
On 2013/12/03 18:54:29, Stephen White wrote:
> Ubernit: the other C-style comments in this file use two spaces between the
star
> and the comment. (I swear I don't have OCD.)

Done.

[Stephen White, 2013-12-03 19:10:23]

https://codereview.chromium.org/100803004/diff/40001/src/core/SkImageFilter.cpp
File src/core/SkImageFilter.cpp (right):

https://codereview.chromium.org/100803004/diff/40001/src/core/SkImageFilter.c...
src/core/SkImageFilter.cpp:58: if (buffer.validate(((inputCount < 0) &&
(fInputCount >= 0)) || (fInputCount == inputCount))) {
I think this will pass validation if a deserialized stream contains -1 as an
input count, and inputCount is also -1. I don't think it should.

[sugoi, 2013-12-03 19:21:49]

https://codereview.chromium.org/100803004/diff/40001/src/core/SkImageFilter.cpp
File src/core/SkImageFilter.cpp (right):

https://codereview.chromium.org/100803004/diff/40001/src/core/SkImageFilter.c...
src/core/SkImageFilter.cpp:58: if (buffer.validate(((inputCount < 0) &&
(fInputCount >= 0)) || (fInputCount == inputCount))) {
On 2013/12/03 19:10:23, Stephen White wrote:
> I think this will pass validation if a deserialized stream contains -1 as an
> input count, and inputCount is also -1. I don't think it should.

Done.

[Stephen White, 2013-12-03 20:19:40]

LGTM

[commit-bot: I haz the power, 2013-12-04 16:46:14]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/100803004/50005

[commit-bot: I haz the power, 2013-12-04 16:46:16]

Presubmit check for 100803004-50005 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com')

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[bsalomon, 2013-12-04 18:42:52]

On 2013/12/04 16:46:16, I haz the power (commit-bot) wrote:
> Presubmit check for 100803004-50005 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> Since the CL is editing public API, you must have an LGTM from one of:
> ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
> 'bsalomon@google.com')
> 
> Was the presubmit check useful? Please send feedback & hate mail to
> maruel@chromium.org!

lgtm

[commit-bot: I haz the power, 2013-12-04 18:46:53]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/100803004/50005

[commit-bot: I haz the power, 2013-12-04 20:07:49]

Change committed as 12492