Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1008023002: Clean up libjingle.gyp and remove references to libpeer_target_type. (Closed)

Created:
5 years, 9 months ago by tommi (sloooow) - chröme
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up libjingle.gyp and remove references to libpeer_target_type. This variable isn't supported any longer. BUG=446865 Committed: https://crrev.com/fd22585c501bdd46f0a511fa5346fc9be1b85f88 Cr-Commit-Position: refs/heads/master@{#321371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -62 lines) Patch
M third_party/libjingle/libjingle.gyp View 6 chunks +6 lines, -62 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tommi (sloooow) - chröme
5 years, 9 months ago (2015-03-13 22:45:01 UTC) #2
kjellander_chromium
lgtm
5 years, 9 months ago (2015-03-14 21:24:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008023002/1
5 years, 9 months ago (2015-03-19 13:49:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 16:33:15 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fd22585c501bdd46f0a511fa5346fc9be1b85f88 Cr-Commit-Position: refs/heads/master@{#321371}
5 years, 9 months ago (2015-03-19 16:33:58 UTC) #7
tommi (sloooow) - chröme
5 years, 9 months ago (2015-03-20 19:27:32 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1025003002/ by tommi@chromium.org.

The reason for reverting is: See if this caused errors on Android. .

Powered by Google App Engine
This is Rietveld 408576698