Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1008003007: Add a menu to the stocks app (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel, ojan
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a menu to the stocks app We should probably move this menu into a view for an individual stock, but for now add it to the main stock screen. R=ojan@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/55be0e63dbe8b45238e486cb93504f2587132c11

Patch Set 1 #

Patch Set 2 : Tweak padding #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -23 lines) Patch
M sky/examples/stocks-fn/lib/stock_app.dart View 5 chunks +24 lines, -12 lines 2 comments Download
A sky/examples/stocks-fn/lib/stock_menu.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M sky/examples/widgets-fn/widgets_app.dart View 2 chunks +8 lines, -9 lines 0 comments Download
M sky/framework/components/popup_menu.dart View 1 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 9 months ago (2015-03-17 23:13:52 UTC) #1
ojan
lgtm https://codereview.chromium.org/1008003007/diff/20001/sky/examples/stocks-fn/lib/stock_app.dart File sky/examples/stocks-fn/lib/stock_app.dart (right): https://codereview.chromium.org/1008003007/diff/20001/sky/examples/stocks-fn/lib/stock_app.dart#newcode58 sky/examples/stocks-fn/lib/stock_app.dart:58: print("_handleMenuClick"); Did you mean to leave this in?
5 years, 9 months ago (2015-03-18 02:09:39 UTC) #3
abarth-chromium
https://codereview.chromium.org/1008003007/diff/20001/sky/examples/stocks-fn/lib/stock_app.dart File sky/examples/stocks-fn/lib/stock_app.dart (right): https://codereview.chromium.org/1008003007/diff/20001/sky/examples/stocks-fn/lib/stock_app.dart#newcode58 sky/examples/stocks-fn/lib/stock_app.dart:58: print("_handleMenuClick"); On 2015/03/18 at 02:09:39, ojan wrote: > Did ...
5 years, 9 months ago (2015-03-18 02:19:58 UTC) #4
abarth-chromium
5 years, 9 months ago (2015-03-18 02:22:27 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
55be0e63dbe8b45238e486cb93504f2587132c11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698