Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1008003004: [ARM64] [turbofan] Improve construction of doubles. (Closed)

Created:
5 years, 9 months ago by jbramley
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev, m.m.capewell
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM64] [turbofan] Improve construction of doubles. Improve the code generated for construction of a 64-bit floating point number from two 32-bit integers. Previously, this moved FP->core, inserted, then moved core->FP for each half. Now, we construct the double in an X register and move core->FP. Typically, the temporary register aliases the input register, so the sequence improves from six to two instructions. Patch from Martyn Capewell <m.m.capewell@googlemail.com>;. BUG= Committed: https://crrev.com/12993637118b25194642666db6c3ce44d9052d94 Cr-Commit-Position: refs/heads/master@{#27227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 4 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +17 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbramley
5 years, 9 months ago (2015-03-16 14:43:04 UTC) #2
Benedikt Meurer
Love it, LGTM!
5 years, 9 months ago (2015-03-16 16:36:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008003004/1
5 years, 9 months ago (2015-03-16 16:53:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 17:15:21 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 17:15:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12993637118b25194642666db6c3ce44d9052d94
Cr-Commit-Position: refs/heads/master@{#27227}

Powered by Google App Engine
This is Rietveld 408576698