Teach the PlatformNotificationContext how to delete notifications.

content/browser/notifications/platform_notification_context_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/notifications/platform_notification_context.h"
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "content/browser/notifications/notification_database_data.h"
 #include "content/public/test/test_browser_thread_bundle.h"
@@ skipping 14 matching lines @@
     success_ = success;
     database_data_ = database_data;
   }
 
   // Callback to provide when writing a notification to the database.
   void DidWriteNotificationData(bool success, int64_t notification_id) {
     success_ = success;
     notification_id_ = notification_id;
   }
 
+  // Callback to provide when deleting notification data from the database.
+  void DidDeleteNotificationData(bool success) {
+    success_ = success;
+  }
+
  protected:
   // Creates a new PlatformNotificationContext instance. When using this method,
   // the underlying database will always be created in memory. The current
   // message loop proxy will be used as the task runner.
   PlatformNotificationContext* CreatePlatformNotificationContext() {
     PlatformNotificationContext* context =
         new PlatformNotificationContext(base::FilePath());
 
     context->SetTaskRunnerForTesting(base::MessageLoopProxy::current());
     return context;
@@ skipping 63 matching lines @@
 
   base::RunLoop().RunUntilIdle();
 
   // The read operation should have succeeded, with the right notification.
   ASSERT_TRUE(success());
 
   const NotificationDatabaseData& read_database_data = database_data();
   EXPECT_EQ(notification_database_data.origin, read_database_data.origin);
 }
 
+TEST_F(PlatformNotificationContextTest, DeleteInvalidNotification) {
+  scoped_refptr<PlatformNotificationContext> context =
+      CreatePlatformNotificationContext();
+
+  context->DeleteNotificationData(
+      42 /* notification_id */,
+      GURL("https://example.com"),
+      base::Bind(&PlatformNotificationContextTest::DidDeleteNotificationData,
+                 base::Unretained(this)));
+
+  base::RunLoop().RunUntilIdle();
+
+  // The notification did not exist, so DeleteNotificationData() should inform
+  // us of that. Most callers won't actually care about this return status
+  // except for correctness reasons - their goal has been satisfied: the data
+  // does not exist in the database.
+  EXPECT_FALSE(success());
+}
+
+TEST_F(PlatformNotificationContextTest, DeleteNotification) {
+  scoped_refptr<PlatformNotificationContext> context =
+      CreatePlatformNotificationContext();
+
+  GURL origin("https://example.com");
+  NotificationDatabaseData notification_database_data;
+
+  context->WriteNotificationData(
+      origin,
+      notification_database_data,
+      base::Bind(&PlatformNotificationContextTest::DidWriteNotificationData,
+                 base::Unretained(this)));
+
+  base::RunLoop().RunUntilIdle();
+
+  // The write operation should have succeeded with a notification id.
+  ASSERT_TRUE(success());
+  EXPECT_GT(notification_id(), 0);
+
+  context->DeleteNotificationData(
+      notification_id(),
+      origin,
+      base::Bind(&PlatformNotificationContextTest::DidDeleteNotificationData,
+                 base::Unretained(this)));
+
+  base::RunLoop().RunUntilIdle();
+
+  // The notification existed, so it should have been removed successfully.
+  ASSERT_TRUE(success());
+
+  context->ReadNotificationData(
+      notification_id(),
+      origin,
+      base::Bind(&PlatformNotificationContextTest::DidReadNotificationData,
+                 base::Unretained(this)));
+
+  base::RunLoop().RunUntilIdle();
+
+  // The notification was removed, so we shouldn't be able to read it from
+  // the database anymore.
+  EXPECT_FALSE(success());
+}
+
 }  // namespace content