Teach the PlatformNotificationContext how to delete notifications.

content/browser/notifications/platform_notification_context.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/notifications/platform_notification_context.h"
 
 #include "base/threading/sequenced_worker_pool.h"
 #include "content/browser/notifications/notification_database.h"
 #include "content/browser/notifications/notification_database_data.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 96 matching lines @@
 
   // TODO(peter): Record UMA on |status| for reading from the database.
   // TODO(peter): Do the DeleteAndStartOver dance for STATUS_ERROR_CORRUPTED.
 
   BrowserThread::PostTask(
       BrowserThread::IO,
       FROM_HERE,
       base::Bind(callback, false /* success */, 0 /* notification_id */));
 }
 
+void PlatformNotificationContext::DeleteNotificationData(
+    int64_t notification_id,
+    const GURL& origin,
+    const DeleteResultCallback& callback) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  LazyInitialize(
+       base::Bind(&PlatformNotificationContext::DoDeleteNotificationData,
+                  this, notification_id, origin, callback),
+       base::Bind(callback, false /* success */));
+}
+
+void PlatformNotificationContext::DoDeleteNotificationData(
+    int64_t notification_id,
+    const GURL& origin,
+    const DeleteResultCallback& callback) {
+  DCHECK(task_runner_->RunsTasksOnCurrentThread());
+
+  NotificationDatabase::Status status =
+      database_->DeleteNotificationData(notification_id, origin);
+
+  const bool success = status == NotificationDatabase::STATUS_OK;

[johnme, 2015/03/16 16:55:18]

It doesn't seem ideal to treat STATUS_ERROR_NOT_FOUND the same as other
failures, since for many use cases that's likely to be considered a success
(whereas STATUS_ERROR_FAILED may mean the key is still stored in the DB).

[johnme, 2015/03/16 16:55:18]

It doesn't seem ideal to treat STATUS_ERROR_NOT_FOUND the same as other
failures, since for many use cases that's likely to be considered a success
(whereas STATUS_ERROR_FAILED may mean the key is still stored in the DB).

[Peter Beverloo, 2015/03/16 18:16:51]

This is not the case anymore per new semantics in the NotificationDatabase class
-- deleting a non-existent notification is not considered to be a failure
anymore.

I've updated the tests to reflect this.

+
+  // TODO(peter): Record UMA on |status| for reading from the database.
+  // TODO(peter): Do the DeleteAndStartOver dance for STATUS_ERROR_CORRUPTED.
+
+  BrowserThread::PostTask(BrowserThread::IO,
+                          FROM_HERE,
+                          base::Bind(callback, success));
+}
+
 void PlatformNotificationContext::LazyInitialize(
     const base::Closure& success_closure,
     const base::Closure& failure_closure) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 
   if (!task_runner_) {
     base::SequencedWorkerPool* pool = BrowserThread::GetBlockingPool();
     base::SequencedWorkerPool::SequenceToken token = pool->GetSequenceToken();
 
     task_runner_ = pool->GetSequencedTaskRunner(token);
@@ skipping 37 matching lines @@
 
   return path_.Append(kPlatformNotificationsDirectory);
 }
 
 void PlatformNotificationContext::SetTaskRunnerForTesting(
     const scoped_refptr<base::SequencedTaskRunner>& task_runner) {
   task_runner_ = task_runner;
 }
 
 }  // namespace content