Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1008003002: [Webapp Refactor] Implements Me2MeConnectFlow as an object. (Closed)

Created:
5 years, 9 months ago by kelvinp
Modified:
5 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Webapp Refactor] Implements Me2MeConnectFlow as an object. This CL encapsulates Me2MeConnectFlow as an object. Ultimately, we would like to create an interface to abstract connection, error handling on the It2MeFlow and the Me2MeFlow on the desktop remoting end. Summary of changes: 1. Move pairingInfo into remoting.Host. 2. Update the field names of remoting.pairingInfo to match storage keys. 3. Move code from crd_connect.js into Me2MeConnectFlow. BUG=466406 Committed: https://crrev.com/4827d56c1339eea1a64601ed5ea44dc76d025486 Cr-Commit-Position: refs/heads/master@{#320832}

Patch Set 1 : Rename pairing info fields to match storage keys #

Patch Set 2 : Move code from crd_connect.js -> me2me_connect_flow.js #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -90 lines) Patch
M remoting/webapp/crd/js/client_plugin_impl.js View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/webapp/crd/js/crd_connect.js View 1 2 2 chunks +5 lines, -76 lines 0 comments Download
M remoting/webapp/crd/js/credentials_provider.js View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/webapp/crd/js/desktop_remoting.js View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
M remoting/webapp/crd/js/host.js View 2 chunks +5 lines, -0 lines 0 comments Download
M remoting/webapp/crd/js/me2me_connect_flow.js View 1 2 2 chunks +70 lines, -0 lines 0 comments Download
M remoting/webapp/crd/js/session_connector_impl.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
kelvinp
PTAL
5 years, 9 months ago (2015-03-13 22:17:47 UTC) #3
kelvinp
Ping
5 years, 9 months ago (2015-03-16 18:32:30 UTC) #4
Jamie
lgtm
5 years, 9 months ago (2015-03-16 20:48:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008003002/40001
5 years, 9 months ago (2015-03-16 21:01:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/45543)
5 years, 9 months ago (2015-03-16 22:12:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1008003002/60001
5 years, 9 months ago (2015-03-16 22:36:00 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 9 months ago (2015-03-17 00:43:13 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 00:43:41 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4827d56c1339eea1a64601ed5ea44dc76d025486
Cr-Commit-Position: refs/heads/master@{#320832}

Powered by Google App Engine
This is Rietveld 408576698