Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1007993006: Fix for the flash Text layout framework problems with win32k lockdown mode on Windows 8+ (Closed)

Created:
5 years, 9 months ago by ananta
Modified:
5 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for the flash Text layout framework problems with win32k lockdown mode on Windows 8+ Flash while rendering text calls into pepper to create a canvas and then sends IPCs like PpapiHostMsg_Flash_DrawGlyphs to draw into the canvas. In Win32K lockdown mode we create a memory canvas instance (ImageDataSimpleBackend). This class returns NULL in its GetPlatformCanvas implementation which causes the OnDrawGlyphs call to bail. Fix is to call the GetCanvas function instead of GetPlatformCanvas. Both functions do the same thing. BUG=468418 R=cpu Committed: https://crrev.com/df69a28d5b46c2d9a25a14b9fc427a26ecf9f55f Cr-Commit-Position: refs/heads/master@{#321281}

Patch Set 1 #

Patch Set 2 : Reverted changes to dxva_video_decode_accelerator.cc #

Patch Set 3 : Replace calls to GetPlatformCanvas with GetCanvas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/renderer/pepper/pepper_flash_renderer_host.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ananta
5 years, 9 months ago (2015-03-19 01:52:31 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
5 years, 9 months ago (2015-03-19 03:01:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007993006/40001
5 years, 9 months ago (2015-03-19 03:04:45 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-19 03:11:37 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 03:12:26 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/df69a28d5b46c2d9a25a14b9fc427a26ecf9f55f
Cr-Commit-Position: refs/heads/master@{#321281}

Powered by Google App Engine
This is Rietveld 408576698