chrome/browser/ui/toolbar/wrench_menu_model.h - Issue 1007993004: Restructure the wrench menu into an action based order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.h

Issue 1007993004: Restructure the wrench menu into an action based order (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Corrected bookmark test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/toolbar/bookmark_sub_menu_model.cc ('K') | « chrome/browser/ui/toolbar/bookmark_sub_menu_model.cc ('k') | chrome/browser/ui/toolbar/wrench_menu_model.cc » ('j') | chrome/browser/ui/toolbar/wrench_menu_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/wrench_menu_model.h

diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.h b/chrome/browser/ui/toolbar/wrench_menu_model.h

index da4c431dd556b5c5bbd219f2fd6971a21da23625..6e0b0af51ccc17a6f7148e0fc7230bbc2dbc6a01 100644

--- a/chrome/browser/ui/toolbar/wrench_menu_model.h

+++ b/chrome/browser/ui/toolbar/wrench_menu_model.h

@@ -190,7 +190,7 @@ class WrenchMenuModel : public ui::SimpleMenuModel,

void Build();

- void AddGlobalErrorMenuItems();

+ bool AddGlobalErrorMenuItems();

Peter Kasting 2015/03/30 19:37:02 Nit: Please add a comment explaining what this fun

edwardjung 2015/03/31 11:44:05 Done.

// Appends everything needed for the clipboard menu: a menu break, the

// clipboard menu content and the finalizing menu break.