Fixes to {} handling in GN.

Fixes to {} handling in GN.

This disallows standalone {} blocks. Fortunately, we did not use these in
the Chrome build.

This eliminates the ambiguity of whether foo("bar") {} is a function that takes
a block (like a target definition) or a standalone function followed by a
standalone block.

Previously we would put the block on the function if a function preceeded it,
or keep the block standalone if there wasn't a function. Additionally,
functions that weren't expecting a block would silently ignore it, which
produced some weird cases.

This additionally adds checks for functions that don't expect blocks.

BUG=434519
R=scottmg@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/989adc8450ef29ee2c902724323e68aa50e466b0

[brettw, 2015-03-13 21:54:09]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-03-13 21:58:02]

lgtm

[brettw, 2015-03-13 23:00:07]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-03-13 23:00:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007963003/1

[commit-bot: I haz the power, 2015-03-13 23:47:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-13 23:47:56]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brettw, 2015-03-14 05:07:35]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-03-14 05:07:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007963003/1

[commit-bot: I haz the power, 2015-03-14 05:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-14 05:51:22]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2015-03-14 17:30:34]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-03-14 17:30:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007963003/1

[commit-bot: I haz the power, 2015-03-14 18:13:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-14 18:13:36]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brettw, 2015-03-16 17:02:07]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-03-16 17:02:08]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1007963003/#ps20001
(title: "merge")

[commit-bot: I haz the power, 2015-03-16 17:02:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007963003/20001

[commit-bot: I haz the power, 2015-03-16 17:49:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-16 17:49:50]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[commit-bot: I haz the power, 2015-03-16 17:54:32]

Patchset 2 (id:??) landed as
https://crrev.com/989adc8450ef29ee2c902724323e68aa50e466b0
Cr-Commit-Position: refs/heads/master@{#320749}

[brettw, 2015-03-16 17:54:43]

Committed patchset #2 (id:20001) manually as
989adc8450ef29ee2c902724323e68aa50e466b0 (presubmit successful).