Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1007953002: Fixing Telemetry drag_unittest.py fail on Mac OSX. (Closed)

Created:
5 years, 9 months ago by ssid
Modified:
5 years, 9 months ago
Reviewers:
Sami, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing Telemetry drag_unittest.py fail on Mac OSX. This CL adds handling of the PageActionNotSupported exception for the test to pass on systems with older browser versions, which does not support drag gesture yet. BUG=467090 Committed: https://crrev.com/7c072f8320d9fc3552eae96a5bfd6d6afa0ff0a4 Cr-Commit-Position: refs/heads/master@{#320720}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added warning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M tools/telemetry/telemetry/page/actions/drag_unittest.py View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
ssid
PTAL.
5 years, 9 months ago (2015-03-13 19:39:26 UTC) #2
Sami
https://codereview.chromium.org/1007953002/diff/1/tools/telemetry/telemetry/page/actions/drag_unittest.py File tools/telemetry/telemetry/page/actions/drag_unittest.py (right): https://codereview.chromium.org/1007953002/diff/1/tools/telemetry/telemetry/page/actions/drag_unittest.py#newcode35 tools/telemetry/telemetry/page/actions/drag_unittest.py:35: return Please print a message with logging.warning here so ...
5 years, 9 months ago (2015-03-13 20:15:40 UTC) #3
ssid
Added the warning.
5 years, 9 months ago (2015-03-16 10:32:11 UTC) #4
Sami
Thanks, lgtm.
5 years, 9 months ago (2015-03-16 10:43:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007953002/20001
5 years, 9 months ago (2015-03-16 10:59:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 13:05:22 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 13:06:05 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c072f8320d9fc3552eae96a5bfd6d6afa0ff0a4
Cr-Commit-Position: refs/heads/master@{#320720}

Powered by Google App Engine
This is Rietveld 408576698