[ninja-xcode] Include action inputs in hybrid builds.

[ninja-xcode] Include action inputs in hybrid builds.

This gathers more input files for the 'sources_for_indexing' target.

BUG=466048
R=sdefresne@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/2cd9d0633c96496a56e87d5ff7177d0079b2f1c6

[justincohen, 2015-03-13 19:34:33]

justincohen@chromium.org changed reviewers:
+ noyau@chromium.org, sdefresne@chromium.org

[justincohen, 2015-03-13 19:34:34]

PTAL.  noyau@ Can you patch this in and see if it works for you?  This adds a
few thousand new files to the Chromium sources project.  Check if you get a
performance hit -- I didn't notice one.

[noyau (Ping after 24h), 2015-03-16 10:22:56]

On 2015/03/13 19:34:34, justincohen wrote:
> PTAL.  noyau@ Can you patch this in and see if it works for you?  This adds a
> few thousand new files to the Chromium sources project.  Check if you get a
> performance hit -- I didn't notice one.

It works. I haven't noticed any performance hit. And having all those files
indexed is great! Thanks.

However there are issues because of the files in ios_internal/build referenced
in the gyp: Everything in the xcode browser view is indented below another layer
of '..', and those three files (grit_resource_ids, grit_whitelist.txt and
official/create_canary_version_file.py) are listed at the top level.

Is there anyway to make the hierarchy in the source_for_indexing target start
from src instead of starting from ios_internal/build and going up? I understand
that the file references do need to be that way, but the folder structure could
be layered differently.

[sdefresne, 2015-03-16 12:19:50]

On 2015/03/16 10:22:56, noyau wrote:
> On 2015/03/13 19:34:34, justincohen wrote:
> > PTAL.  noyau@ Can you patch this in and see if it works for you?  This adds
a
> > few thousand new files to the Chromium sources project.  Check if you get a
> > performance hit -- I didn't notice one.
> 
> It works. I haven't noticed any performance hit. And having all those files
> indexed is great! Thanks.
> 
> However there are issues because of the files in ios_internal/build referenced
> in the gyp: Everything in the xcode browser view is indented below another
layer
> of '..', and those three files (grit_resource_ids, grit_whitelist.txt and
> official/create_canary_version_file.py) are listed at the top level.
> 
> Is there anyway to make the hierarchy in the source_for_indexing target start
> from src instead of starting from ios_internal/build and going up? I
understand
> that the file references do need to be that way, but the folder structure
could
> be layered differently.

Sadly no.

[sdefresne, 2015-03-16 12:19:58]

lgtm

[justincohen, 2015-03-16 13:28:02]

justincohen@chromium.org changed reviewers:
+ mark@chromium.org

[justincohen, 2015-03-16 13:28:02]

mark for OWNERS.  PTAL!

[justincohen, 2015-03-16 16:34:30]

Committed patchset #1 (id:1) manually as
2cd9d0633c96496a56e87d5ff7177d0079b2f1c6 (presubmit successful).

[justincohen, 2015-03-16 16:35:04]

Sorry, I don't know why I requested an OWNERS review, this should be good with
sdefresne's review.  Thanks!