Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1007913002: Add logging for missing resource. (Closed)

Created:
5 years, 9 months ago by alokp
Modified:
5 years, 9 months ago
Reviewers:
jamesr, DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add logging for missing resource. Html viewer is hitting a NOTREACHED due to a missing resource. Added logging for the resource name so that it can be tracked. Committed: https://crrev.com/0d1603db620483651988c7f1269cadd7c001b313 Cr-Commit-Position: refs/heads/master@{#320759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/services/html_viewer/blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
alokp
5 years, 9 months ago (2015-03-13 18:39:12 UTC) #2
DaveMoore
lgtm
5 years, 9 months ago (2015-03-13 19:09:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007913002/1
5 years, 9 months ago (2015-03-13 19:28:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/49597)
5 years, 9 months ago (2015-03-13 19:50:16 UTC) #7
alokp
jamesr: OWNER for mojo. aa@, html_viewer OWNER, is no longer active on this project.
5 years, 9 months ago (2015-03-13 20:13:07 UTC) #9
jamesr
lgtm
5 years, 9 months ago (2015-03-16 18:15:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007913002/1
5 years, 9 months ago (2015-03-16 18:18:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 18:49:27 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 18:50:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d1603db620483651988c7f1269cadd7c001b313
Cr-Commit-Position: refs/heads/master@{#320759}

Powered by Google App Engine
This is Rietveld 408576698