Issue 1007893005: Clean up stock_app.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1007893005: Clean up stock_app.dart (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
rafaelw, ojan

CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Clean up stock_app.dart This CL cleans up stock_app.dart to better separate concerns now that we have StyleNode. Also, this CL introduces IconButton, which will grow to include an ink effect in the future, and makes the background of the search bar white. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e252977e5b22685a1b4fdb14eda40c78935ea50a

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -95 lines)			Patch
M	sky/examples/stocks-fn/lib/stock_app.dart	View	5 chunks	+65 lines, -64 lines	0 comments	Download
M	sky/framework/components/action_bar.dart	View	1 chunk	+21 lines, -11 lines	0 comments	Download
M	sky/framework/components/drawer.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/framework/components/icon.dart	View	2 chunks	+2 lines, -8 lines	0 comments	Download
A	sky/framework/components/icon_button.dart	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	sky/framework/components/menu_item.dart	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	sky/framework/components/scaffold.dart	View	3 chunks	+4 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 9 months ago (2015-03-25 01:00:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e252977e5b22685a1b4fdb14eda40c78935ea50a (presubmit successful).