Fixing install-build-deps.sh to install the correct version of libstdc++ with debugging symbols.

Fixing install-build-deps.sh to install the correct version of libstdc++ with debugging symbols.

Committed: https://crrev.com/ad917d11c19c9ca8bda612e9a566168f3d445578
Cr-Commit-Position: refs/heads/master@{#321011}

[lfg, 2015-03-16 16:45:19]

lfg@chromium.org changed reviewers:
+ dpranke@chromium.org

[lfg, 2015-03-16 16:45:19]

Hi, PTAL.

We currently install libstdc++6-4.6-dbg, but libstdc++6 on current {Goo,U}buntu
is version 4.8.

[Dirk Pranke, 2015-03-16 17:08:57]

Are you sure we don't need the older version for compatibility w/ Precise?

[lfg, 2015-03-16 17:40:38]

On 2015/03/16 17:08:57, Dirk Pranke wrote:
> Are you sure we don't need the older version for compatibility w/ Precise?

They are conflicting, so we can't have both. Either we can have symbols on
precise or trusty, but I think by now the vast majority of developers should be
on trusty.

The only consequences of not having the symbols is when debugging stl types in
gdb.

Another option would be to detect the available versions and install the
appropriate version (it seems we already do that with mesa).

[Dirk Pranke, 2015-03-16 18:50:13]

dpranke@chromium.org changed reviewers:
+ thestig@chromium.org

[Dirk Pranke, 2015-03-16 18:51:19]

The script is also run on the bots, which are still mostly Precise. So,
installing a Trusty lib makes me nervous.

I would be okay with a script that auto-detected the o/s version and did the
right thing.

Otherwise, I will also defer to thestig@ if he thinks this is the way to go :).

[Lei Zhang, 2015-03-16 19:27:17]

On 2015/03/16 18:51:19, Dirk Pranke wrote:
> The script is also run on the bots, which are still mostly Precise. So,
> installing a Trusty lib makes me nervous.

Ya, patch set 1 will likely break some bots.

> I would be okay with a script that auto-detected the o/s version and did the
> right thing.

SGTM.

[lfg, 2015-03-16 19:50:16]

On 2015/03/16 19:27:17, Lei Zhang wrote:
> > I would be okay with a script that auto-detected the o/s version and did the
> > right thing.
> 
> SGTM.

Please, take another look. I've updated the script so it detects the proper
version and installs the appropriate libstdc++-dbg.

[Lei Zhang, 2015-03-16 20:45:42]

https://codereview.chromium.org/1007893004/diff/20001/build/install-build-dep...
File build/install-build-deps.sh (right):

https://codereview.chromium.org/1007893004/diff/20001/build/install-build-dep...
build/install-build-deps.sh:142: # Find the proper version of
libstdc++6-4.x-dbg.
I think the logic should be:
precise -> 4.6
trusty -> 4.8
else 4.9

Where we assume "else" means newer than trusty. Everything between precise and
trusty has reached EOL and shouldn't be supported. I'll make a pass after this
CL to clean up the script.

https://codereview.chromium.org/1007893004/diff/20001/build/install-build-dep...
build/install-build-deps.sh:143: if [ "x$lsb_release" == "xtrusty" ]; then
A single '=' will do, '==' is a bashism.

[lfg, 2015-03-16 20:58:47]

Done, please take a look.

https://codereview.chromium.org/1007893004/diff/20001/build/install-build-dep...
File build/install-build-deps.sh (right):

https://codereview.chromium.org/1007893004/diff/20001/build/install-build-dep...
build/install-build-deps.sh:142: # Find the proper version of
libstdc++6-4.x-dbg.
On 2015/03/16 20:45:42, Lei Zhang wrote:
> I think the logic should be:
> precise -> 4.6
> trusty -> 4.8
> else 4.9
> 
> Where we assume "else" means newer than trusty. Everything between precise and
> trusty has reached EOL and shouldn't be supported. I'll make a pass after this
> CL to clean up the script.

Done.

https://codereview.chromium.org/1007893004/diff/20001/build/install-build-dep...
build/install-build-deps.sh:143: if [ "x$lsb_release" == "xtrusty" ]; then
On 2015/03/16 20:45:42, Lei Zhang wrote:
> A single '=' will do, '==' is a bashism.

Done.

[Lei Zhang, 2015-03-16 21:06:15]

lgtm

[lfg, 2015-03-17 22:24:05]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2015-03-17 22:26:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007893004/40001

[commit-bot: I haz the power, 2015-03-17 22:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-17 22:47:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lfg, 2015-03-17 22:57:28]

HI dpranke, can I get an owner rubber-stamp for this?

[Dirk Pranke, 2015-03-17 23:05:28]

lgtm

[Lei Zhang, 2015-03-17 23:23:49]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-03-17 23:24:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007893004/40001

[commit-bot: I haz the power, 2015-03-17 23:28:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-17 23:28:43]

Patchset 3 (id:??) landed as
https://crrev.com/ad917d11c19c9ca8bda612e9a566168f3d445578
Cr-Commit-Position: refs/heads/master@{#321011}