[Password manager tests automation] Tests for Adobe and Github

components/test/data/password_manager/automated_tests/tests.py

Index: components/test/data/password_manager/automated_tests/tests.py
diff --git a/components/test/data/password_manager/automated_tests/tests.py b/components/test/data/password_manager/automated_tests/tests.py
index c69ab5176510070191e9bae47453ca705a0f7ccd..56a654f06fc69f572f1b737b86fde029b4c2879f 100644
--- a/components/test/data/password_manager/automated_tests/tests.py
+++ b/components/test/data/password_manager/automated_tests/tests.py
@@ -27,7 +27,6 @@ class TypeOfTestedWebsites:
   def __init__(self):
     pass
 
-

[vabr (Chromium), 2015/03/13 16:10:31]

nit: Please keep two spaces between the classes. I vaguely recall that this is
recommended on the global level. But even if that was wrong, we should do a
different CL to fix the whole file.

[battre, 2015/03/16 10:48:05]

2 newlines is correct. This was a mistake.

Done.

 class Alexa(WebsiteTest):
 
   def Login(self):
@@ -46,6 +45,15 @@ class Facebook(WebsiteTest):
     self.Submit("[name='pass']")
 
 
+class Github(WebsiteTest):
+
+  def Login(self):
+    self.GoTo("https://github.com/login")
+    self.FillUsernameInto("[name='login']")
+    self.FillPasswordInto("[name='password']")
+    self.Submit("[name='commit']")
+
+
 class Google(WebsiteTest):
 
   def Login(self):
@@ -175,6 +183,16 @@ class Yandex(WebsiteTest):
 # Disabled tests.
 
 
+# Fails to save password.

[vabr (Chromium), 2015/03/13 16:10:31]

Ideally we should have a bug for every failing test. But there are already many
disabled tests which don't have a bug yet, so I'll add those in one sweep later.
(The only bug about passwords and adobe I found was http://crbug.com/314595, but
that one is hardly relevant.)

[battre, 2015/03/16 10:48:05]

Thanks for taking care of analyzing the details and filing bugs.

+class Adobe(WebsiteTest):
+
+  def Login(self):
+    self.GoTo("https://adobeid-na1.services.adobe.com/renga-idprovider/pages/login?callback=https%3A%2F%2Fims-na1.adobelogin.com%2Fims%2Fadobeid%2Fadobedotcom2%2FAdobeID%2Ftoken%3Fredirect_uri%3Dhttps%253A%252F%252Fwww.adobe.com%252F%2523from_ims%253Dtrue%2526old_hash%253D%2526client_id%253Dadobedotcom2%2526scope%253Dcreative_cloud%25252CAdobeID%25252Copenid%25252Cgnav%25252Cread_organizations%25252Cadditional_info.projectedProductContext%2526api%253Dauthorize&client_id=adobedotcom2&scope=creative_cloud%2CAdobeID%2Copenid%2Cgnav%2Cread_organizations%2Cadditional_info.projectedProductContext&display=web_v2&denied_callback=https%3A%2F%2Fims-na1.adobelogin.com%2Fims%2Fdenied%2Fadobedotcom2%3Fredirect_uri%3Dhttps%253A%252F%252Fwww.adobe.com%252F%2523from_ims%253Dtrue%2526old_hash%253D%2526client_id%253Dadobedotcom2%2526scope%253Dcreative_cloud%25252CAdobeID%25252Copenid%25252Cgnav%25252Cread_organizations%25252Cadditional_info.projectedProductContext%2526api%253Dauthorize%26response_type%3Dtoken&relay=afebfef8-e2b3-4c0e-9c94-07baf205bae8&locale=en_US&flow_type=token&dc=false&client_redirect=https%3A%2F%2Fims-na1.adobelogin.com%2Fims%2Fredirect%2Fadobedotcom2%3Fclient_redirect%3Dhttps%253A%252F%252Fwww.adobe.com%252F%2523from_ims%253Dtrue%2526old_hash%253D%2526client_id%253Dadobedotcom2%2526scope%253Dcreative_cloud%25252CAdobeID%25252Copenid%25252Cgnav%25252Cread_organizations%25252Cadditional_info.projectedProductContext%2526api%253Dauthorize&idp_flow_type=login")

[vabr (Chromium), 2015/03/13 16:10:31]

That's an impressive URL. :)

+    self.FillUsernameInto("[name='username']")
+    self.FillPasswordInto("[name='password']")
+    self.Submit("#sign_in")
+
+
 # Bug not reproducible without test.
 class Amazon(WebsiteTest):
 
@@ -342,6 +360,7 @@ def Tests(environment, tests_to_run=None):
   working_tests = {
     "alexa": Alexa("alexa"),
     "facebook": Facebook("facebook"),
+    "github": Github("github"),
     "google": Google("google"),
     "imgur": Imgur("imgur"),
     "liveinternet": Liveinternet("liveinternet"),
@@ -359,6 +378,7 @@ def Tests(environment, tests_to_run=None):
   }
 
   disabled_tests = {
+    "adobe": Adobe("adobe"), # Password saving not offered.
     "amazon": Amazon("amazon"), # Bug not reproducible without test.
     "ask": Ask("ask"), # Password not saved.
     "baidu": Baidu("baidu"), # Password not saved.
@@ -371,7 +391,7 @@ def Tests(environment, tests_to_run=None):
     "live": Live("live", username_not_auto=True),  # http://crbug.com/367768
     "163": One63("163"), # http://crbug.com/368690
     "vube": Vube("vube"), # http://crbug.com/368690
-    "ziddu": Ziddu("ziddu"), #Password not saved
+    "ziddu": Ziddu("ziddu"), # Password not saved.
   }
 
   if tests_to_run: