Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1007883002:
[Password manager tests automation] Tests for Adobe and Github (Closed)
|
Created:
5 years, 9 months ago by battre Modified:
5 years, 9 months ago Reviewers:
vabr (Chromium) CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Password manager tests automation] Tests for Adobe and Github
Adobe test fails, Github test passes.
BUG=369521
Committed: https://crrev.com/d26d0cb673b4f9af7d6b31e75769ae487b1876f4
Cr-Commit-Position: refs/heads/master@{#320714}
Patch Set 1 #
Total comments: 5
Patch Set 2 : Addressed comments" #Patch Set 3 : Obey to the presubmit overloads. #Messages
Total messages: 14 (6 generated)
battre@chromium.org changed reviewers: + vabr@chromium.org
Hi Vaclav, could you please review this? Thanks, Dominic
LGTM, Thanks! https://codereview.chromium.org/1007883002/diff/1/components/test/data/passwo... File components/test/data/password_manager/automated_tests/tests.py (left): https://codereview.chromium.org/1007883002/diff/1/components/test/data/passwo... components/test/data/password_manager/automated_tests/tests.py:30: nit: Please keep two spaces between the classes. I vaguely recall that this is recommended on the global level. But even if that was wrong, we should do a different CL to fix the whole file. https://codereview.chromium.org/1007883002/diff/1/components/test/data/passwo... File components/test/data/password_manager/automated_tests/tests.py (right): https://codereview.chromium.org/1007883002/diff/1/components/test/data/passwo... components/test/data/password_manager/automated_tests/tests.py:186: # Fails to save password. Ideally we should have a bug for every failing test. But there are already many disabled tests which don't have a bug yet, so I'll add those in one sweep later. (The only bug about passwords and adobe I found was http://crbug.com/314595, but that one is hardly relevant.) https://codereview.chromium.org/1007883002/diff/1/components/test/data/passwo... components/test/data/password_manager/automated_tests/tests.py:190: self.GoTo("https://adobeid-na1.services.adobe.com/renga-idprovider/pages/login?callback=https%3A%2F%2Fims-na1.adobelogin.com%2Fims%2Fadobeid%2Fadobedotcom2%2FAdobeID%2Ftoken%3Fredirect_uri%3Dhttps%253A%252F%252Fwww.adobe.com%252F%2523from_ims%253Dtrue%2526old_hash%253D%2526client_id%253Dadobedotcom2%2526scope%253Dcreative_cloud%25252CAdobeID%25252Copenid%25252Cgnav%25252Cread_organizations%25252Cadditional_info.projectedProductContext%2526api%253Dauthorize&client_id=adobedotcom2&scope=creative_cloud%2CAdobeID%2Copenid%2Cgnav%2Cread_organizations%2Cadditional_info.projectedProductContext&display=web_v2&denied_callback=https%3A%2F%2Fims-na1.adobelogin.com%2Fims%2Fdenied%2Fadobedotcom2%3Fredirect_uri%3Dhttps%253A%252F%252Fwww.adobe.com%252F%2523from_ims%253Dtrue%2526old_hash%253D%2526client_id%253Dadobedotcom2%2526scope%253Dcreative_cloud%25252CAdobeID%25252Copenid%25252Cgnav%25252Cread_organizations%25252Cadditional_info.projectedProductContext%2526api%253Dauthorize%26response_type%3Dtoken&relay=afebfef8-e2b3-4c0e-9c94-07baf205bae8&locale=en_US&flow_type=token&dc=false&client_redirect=https%3A%2F%2Fims-na1.adobelogin.com%2Fims%2Fredirect%2Fadobedotcom2%3Fclient_redirect%3Dhttps%253A%252F%252Fwww.adobe.com%252F%2523from_ims%253Dtrue%2526old_hash%253D%2526client_id%253Dadobedotcom2%2526scope%253Dcreative_cloud%25252CAdobeID%25252Copenid%25252Cgnav%25252Cread_organizations%25252Cadditional_info.projectedProductContext%2526api%253Dauthorize&idp_flow_type=login") That's an impressive URL. :)
https://codereview.chromium.org/1007883002/diff/1/components/test/data/passwo... File components/test/data/password_manager/automated_tests/tests.py (left): https://codereview.chromium.org/1007883002/diff/1/components/test/data/passwo... components/test/data/password_manager/automated_tests/tests.py:30: On 2015/03/13 16:10:31, vabr (Chromium) wrote: > nit: Please keep two spaces between the classes. I vaguely recall that this is > recommended on the global level. But even if that was wrong, we should do a > different CL to fix the whole file. 2 newlines is correct. This was a mistake. Done. https://codereview.chromium.org/1007883002/diff/1/components/test/data/passwo... File components/test/data/password_manager/automated_tests/tests.py (right): https://codereview.chromium.org/1007883002/diff/1/components/test/data/passwo... components/test/data/password_manager/automated_tests/tests.py:186: # Fails to save password. On 2015/03/13 16:10:31, vabr (Chromium) wrote: > Ideally we should have a bug for every failing test. But there are already many > disabled tests which don't have a bug yet, so I'll add those in one sweep later. > (The only bug about passwords and adobe I found was http://crbug.com/314595, but > that one is hardly relevant.) Thanks for taking care of analyzing the details and filing bugs.
The CQ bit was checked by battre@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org Link to the patchset: https://codereview.chromium.org/1007883002/#ps20001 (title: "Addressed comments"")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007883002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by battre@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org Link to the patchset: https://codereview.chromium.org/1007883002/#ps40001 (title: "Obey to the presubmit overloads.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007883002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/d26d0cb673b4f9af7d6b31e75769ae487b1876f4 Cr-Commit-Position: refs/heads/master@{#320714} |
