Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: runtime/vm/json_stream.cc

Issue 1007863003: Allow Observatory debugger to switch isolates. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/json_stream.cc
diff --git a/runtime/vm/json_stream.cc b/runtime/vm/json_stream.cc
index 388c0d327d330ee0b6800acc81ee737cf5eae971..44992eb02b714b7075263dff18800b293d63a34b 100644
--- a/runtime/vm/json_stream.cc
+++ b/runtime/vm/json_stream.cc
@@ -280,6 +280,9 @@ void JSONStream::PrintProperty(const char* name, intptr_t i) {
void JSONStream::PrintProperty64(const char* name, int64_t i) {
+ // dart2js represents integers as double precision floats, which can
+ // represent anything in the range -2^53 ... 2^53.
+ ASSERT((-0x20000000000000LL <= i) && (i <= 0x20000000000000LL));
Cutch 2015/03/18 20:05:48 How about: #define MAX_JAVASCRIPT_INT 0x2000000000
turnidge 2015/03/26 17:46:58 Added IsJavascriptInt to utils.h.
PrintPropertyName(name);
PrintValue64(i);
}

Powered by Google App Engine
This is Rietveld 408576698