Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 100783002: Adding templating for chrome repos: (Closed)

Created:
7 years ago by mkearney1
Modified:
7 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

Adding templating for chrome repos: store, nacl, multidevice, devtools patch from issue 100723002 Eli, I've added you as a reviewer. This includes very simple starter file for native client so that we can push content migration. I need a native client owner to approve this change. TBR=eliben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238411

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Messages

Total messages: 6 (0 generated)
mkearney1
7 years ago (2013-12-03 01:39:17 UTC) #1
not at google - send to devlin
Didn't look too carefully at content. A couple of comments about structured naming but otherwise ...
7 years ago (2013-12-03 01:44:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/100783002/120001
7 years ago (2013-12-03 05:16:38 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years ago (2013-12-03 12:13:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/100783002/120001
7 years ago (2013-12-03 16:37:04 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-03 16:37:50 UTC) #6
Message was sent while issue was closed.
Change committed as 238411

Powered by Google App Engine
This is Rietveld 408576698