Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 1007813002: [iOS] Upstream autofill component code (Closed)

Created:
5 years, 9 months ago by droger
Modified:
5 years, 9 months ago
Reviewers:
dconnelly, Evan Stade
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream autofill component code This is a straight upstreaming of code that is currently used on iOS. Committed: https://crrev.com/579a70c5b9f2cc0b707cb63c466c9f0e608cec59 Cr-Commit-Position: refs/heads/master@{#320886}

Patch Set 1 #

Patch Set 2 : Added dconnelly to OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2157 lines, -6 lines) Patch
M components/autofill.gypi View 2 chunks +25 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.h View 2 chunks +1 line, -6 lines 0 comments Download
M components/autofill/core/common/autofill_constants.h View 1 chunk +6 lines, -0 lines 0 comments Download
M components/autofill/ios/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A components/autofill/ios/browser/form_suggestion.h View 1 chunk +37 lines, -0 lines 0 comments Download
A components/autofill/ios/browser/form_suggestion.mm View 1 chunk +59 lines, -0 lines 0 comments Download
A components/autofill/ios/browser/js_autofill_manager.h View 1 chunk +51 lines, -0 lines 0 comments Download
A components/autofill/ios/browser/js_autofill_manager.mm View 1 chunk +103 lines, -0 lines 0 comments Download
A components/autofill/ios/browser/js_suggestion_manager.h View 1 chunk +55 lines, -0 lines 0 comments Download
A components/autofill/ios/browser/js_suggestion_manager.mm View 1 chunk +115 lines, -0 lines 0 comments Download
A components/autofill/ios/browser/resources/autofill_controller.js View 1 chunk +1390 lines, -0 lines 0 comments Download
A components/autofill/ios/browser/resources/suggestion_controller.js View 1 chunk +314 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
droger
dconnelly: should you be added to components/autofill/ios/OWNERS?
5 years, 9 months ago (2015-03-13 14:18:45 UTC) #2
dconnelly
On 2015/03/13 14:18:45, droger wrote: > dconnelly: should you be added to components/autofill/ios/OWNERS? yes please ...
5 years, 9 months ago (2015-03-16 10:04:05 UTC) #3
droger
+ estade as autofill OWNER
5 years, 9 months ago (2015-03-16 13:12:18 UTC) #5
Evan Stade
rubber stamp lgtm
5 years, 9 months ago (2015-03-17 01:29:10 UTC) #6
droger
Thanks for the reviews.
5 years, 9 months ago (2015-03-17 08:45:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007813002/20001
5 years, 9 months ago (2015-03-17 08:45:39 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 10:31:25 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 10:31:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/579a70c5b9f2cc0b707cb63c466c9f0e608cec59
Cr-Commit-Position: refs/heads/master@{#320886}

Powered by Google App Engine
This is Rietveld 408576698