Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1007803004: Oilpan: consistently use IsGarbageCollectedMixin<> trait. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
CC:
blink-reviews, oilpan-reviews, dglazkov+blink, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: consistently use IsGarbageCollectedMixin<> trait. Use blink::IsGarbageCollectedMixin<T> to test if the object T implements GarbageCollectedMixin. It handles objects that have multiple GarbageCollectedMixin bases. With that in place for WebPrivatePtr<>'s LifetimeOf trait, SpeechRecognition's specialization for it can be retired. R=haraken BUG=420515 TBR=tkent Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -31 lines) Patch
M Source/modules/speech/SpeechRecognition.h View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/platform/heap/Visitor.h View 3 chunks +18 lines, -18 lines 0 comments Download
M public/platform/WebPrivatePtr.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
sof
please take a look.
5 years, 9 months ago (2015-03-14 06:21:22 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-14 08:35:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007803004/1
5 years, 9 months ago (2015-03-14 09:18:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/28985)
5 years, 9 months ago (2015-03-14 09:35:56 UTC) #7
sof
tkent@: please take a look at the WebPrivatePtr<> change? tia.
5 years, 9 months ago (2015-03-14 09:42:48 UTC) #9
sof
TBRing the public/platform/ change.
5 years, 9 months ago (2015-03-16 06:15:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007803004/1
5 years, 9 months ago (2015-03-16 06:16:03 UTC) #12
tkent
lgtm
5 years, 9 months ago (2015-03-16 06:41:10 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 09:12:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191900

Powered by Google App Engine
This is Rietveld 408576698