chrome/browser/resources/settings/settings_page/settings_page.css - Issue 1007803003: Polymer Settings Scaffold in MD-Settings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_page.css

Issue 1007803003: Polymer Settings Scaffold in MD-Settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Scaffold2

Patch Set: Remove pages to shrink CL Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/settings_main/settings_main.html ('K') | « chrome/browser/resources/settings/settings_main/settings_main.html ('k') | chrome/browser/resources/settings/settings_page/settings_page_header.css » ('j') | chrome/browser/resources/settings/settings_page/settings_page_header.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /* Copyright 2015 The Chromium Authors. All rights reserved.

	2 * Use of this source code is governed by a BSD-style license that can be

	3 * found in the LICENSE file. */

	4

	5 :host {
	Jeremy Klein 2015/03/13 23:51:51 Can we include a fileoverview type comment here to Can we include a fileoverview type comment here to indicate that these are styles shared by all settings pages? michaelpg 2015/03/17 06:30:15 Done. Show quoted text On 2015/03/13 23:51:51, Jeremy Klein wrote: > Can we include a fileoverview type comment here to indicate that these are > styles shared by all settings pages? Done.
	6 -webkit-margin-start: 40px;

	7 -webkit-padding-end: 20px;

	8 -webkit-padding-start: 40px;

	9 padding-bottom: 40px;

	10 padding-top: 40px;

	11 }

	12

	13 :host /deep/ cr-settings-page-header {
	Jeremy Klein 2015/03/13 23:51:51 Shouldn't this just be in the header css? Shouldn't this just be in the header css? michaelpg 2015/03/17 06:30:15 I think it belongs here as it's specifying constra Show quoted text On 2015/03/13 23:51:51, Jeremy Klein wrote: > Shouldn't this just be in the header css? I think it belongs here as it's specifying constraints for the header. The /deep/ is unnecessary though. Jeremy Klein 2015/03/17 06:37:59 I suppose that works for me. Getting rid of the /d Show quoted text On 2015/03/17 06:30:15, michaelpg wrote: > On 2015/03/13 23:51:51, Jeremy Klein wrote: > > Shouldn't this just be in the header css? > > I think it belongs here as it's specifying constraints for the header. The > /deep/ is unnecessary though. I suppose that works for me. Getting rid of the /deep/ is a +.
	14 margin-bottom: 30px;

	15 min-height: 24px;

	16 }

OLD	NEW