Add SpeechSynthesisUtterance attribute on SpeechSynthesisEvent

Add SpeechSynthesisUtterance attribute on SpeechSynthesisEvent

Regarding the latest WebSpeech spec,
SpeechSynthesisUtterance is added to SpeechSynthesisEvent.
It is not implemented yet in blink.
We need to add new attribute on SpeechSynthesisEvent.

BUG=https://dvcs.w3.org/hg/speech-api/raw-file/tip/webspeechapi.html#speechsynthesisevent

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192438

[deejay, 2015-03-13 12:16:17]

djmix.kim@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[deejay, 2015-03-13 12:18:51]

Hi Dominic,

This patch changes for adding SpeechSynthesisUtterance on SpeechSynthesisEvent.

PTAL.

[deejay, 2015-03-17 13:16:24]

djmix.kim@samsung.com changed reviewers:
+ abarth@chromium.org, haraken@chromium.org

[deejay, 2015-03-17 13:17:20]

+ add more reviewer.

Dear all,
Please take a look this commit.

[dmazzoni, 2015-03-17 15:36:47]

Please file a bug and fill in the BUG= line, and provide a url to the spec
change there.

I think this needs an Intent to Implement / Intent to Ship. It can be very short
and to the point but I believe that any web-facing change requires it.

http://www.chromium.org/blink#new-features

[dmazzoni, 2015-03-17 15:38:20]

lgtm

Actually maybe this is trivial enough that it doesn't need an intent to
implement, but please do file the bug.

Code looks good, but you need another OWNER to approve.

[deejay, 2015-03-17 16:10:05]

On 2015/03/17 15:38:20, dmazzoni wrote:
> lgtm
> 
> Actually maybe this is trivial enough that it doesn't need an intent to
> implement, but please do file the bug.
> 
> Code looks good, but you need another OWNER to approve.

Thanks for review.
I've updated description.

[deejay, 2015-03-19 05:02:52]

On 2015/03/17 16:10:05, deejay wrote:

ping.

Dear haraken, abarth.
Could you review this?

[haraken, 2015-03-19 05:04:34]

LGTM

[deejay, 2015-03-19 05:25:43]

The CQ bit was checked by djmix.kim@samsung.com

[commit-bot: I haz the power, 2015-03-19 05:25:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007803002/1

[commit-bot: I haz the power, 2015-03-19 07:38:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-19 07:38:03]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[deejay, 2015-03-19 14:58:18]

The CQ bit was checked by djmix.kim@samsung.com

[commit-bot: I haz the power, 2015-03-19 14:58:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007803002/1

[commit-bot: I haz the power, 2015-03-19 17:09:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-19 17:09:50]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[deejay, 2015-03-20 07:41:59]

The CQ bit was checked by djmix.kim@samsung.com

[commit-bot: I haz the power, 2015-03-20 07:42:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007803002/1

[commit-bot: I haz the power, 2015-03-20 09:46:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-20 09:46:17]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[deejay, 2015-03-20 14:24:37]

On 2015/03/20 09:46:17, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_rel on tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

Dear dmazzoni, haraken.

According comment, it had build errors in some cases.
But It didn't have any build error in my local PC (mac, linux).
In addition, it looks that those errors are not related with my patch.

Could you give me a hint for resolving?

[dmazzoni, 2015-03-20 15:20:31]

On 2015/03/20 14:24:37, deejay wrote:
> On 2015/03/20 09:46:17, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   linux_blink_rel on tryserver.blink (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)
> 
> Dear dmazzoni, haraken.
> 
> According comment, it had build errors in some cases.
> But It didn't have any build error in my local PC (mac, linux).
> In addition, it looks that those errors are not related with my patch.
> 
> Could you give me a hint for resolving?

These two failures *are* related to your patch:

webexposed/global-interface-listing.html
virtual/stable/webexposed/global-interface-listing.html

Those files are basically guards against accidentally exposing a new
public-facing web API. You have to modify both of those to make it clear that
this change is intentional.

[deejay, 2015-03-22 00:14:50]

On 2015/03/20 15:20:31, dmazzoni wrote:
> On 2015/03/20 14:24:37, deejay wrote:
> > On 2015/03/20 09:46:17, I haz the power (commit-bot) wrote:
> > > Try jobs failed on following builders:
> > >   linux_blink_rel on tryserver.blink (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)
> > 
> > Dear dmazzoni, haraken.
> > 
> > According comment, it had build errors in some cases.
> > But It didn't have any build error in my local PC (mac, linux).
> > In addition, it looks that those errors are not related with my patch.
> > 
> > Could you give me a hint for resolving?
> 
> These two failures *are* related to your patch:
> 
> webexposed/global-interface-listing.html
> virtual/stable/webexposed/global-interface-listing.html
> 
> Those files are basically guards against accidentally exposing a new
> public-facing web API. You have to modify both of those to make it clear that
> this change is intentional.

Thanks for advise.
I'll check this issue asap.

[deejay, 2015-03-22 12:16:16]

On 2015/03/22 00:14:50, deejay wrote:
> On 2015/03/20 15:20:31, dmazzoni wrote:
> > On 2015/03/20 14:24:37, deejay wrote:
> > > On 2015/03/20 09:46:17, I haz the power (commit-bot) wrote:
> > > > Try jobs failed on following builders:
> > > >   linux_blink_rel on tryserver.blink (JOB_FAILED,
> > > >
> > >
> >
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)
> > > 
> > > Dear dmazzoni, haraken.
> > > 
> > > According comment, it had build errors in some cases.
> > > But It didn't have any build error in my local PC (mac, linux).
> > > In addition, it looks that those errors are not related with my patch.
> > > 
> > > Could you give me a hint for resolving?
> > 
> > These two failures *are* related to your patch:
> > 
> > webexposed/global-interface-listing.html
> > virtual/stable/webexposed/global-interface-listing.html
> > 
> > Those files are basically guards against accidentally exposing a new
> > public-facing web API. You have to modify both of those to make it clear
that
> > this change is intentional.
> 
> Thanks for advise.
> I'll check this issue asap.

@Dominic,
I've updated new patchset.
Now, can I try to commit this CL or do I need to get a review again?
I wait your feedback.

[dmazzoni, 2015-03-22 15:51:15]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-03-22 15:51:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1007803002/#ps20001
(title: "fix build error")

[commit-bot: I haz the power, 2015-03-22 15:51:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007803002/20001

[dmazzoni, 2015-03-22 16:01:47]

Ok to commit, thanks!
On Mar 22, 2015 5:16 AM, <djmix.kim@samsung.com> wrote:

> On 2015/03/22 00:14:50, deejay wrote:
>
>> On 2015/03/20 15:20:31, dmazzoni wrote:
>> > On 2015/03/20 14:24:37, deejay wrote:
>> > > On 2015/03/20 09:46:17, I haz the power (commit-bot) wrote:
>> > > > Try jobs failed on following builders:
>> > > >   linux_blink_rel on tryserver.blink (JOB_FAILED,
>> > > >
>> > >
>> >
>>
>
> http://build.chromium.org/p/tryserver.blink/builders/
> linux_blink_rel/builds/53319)
>
>> > >
>> > > Dear dmazzoni, haraken.
>> > >
>> > > According comment, it had build errors in some cases.
>> > > But It didn't have any build error in my local PC (mac, linux).
>> > > In addition, it looks that those errors are not related with my patch.
>> > >
>> > > Could you give me a hint for resolving?
>> >
>> > These two failures *are* related to your patch:
>> >
>> > webexposed/global-interface-listing.html
>> > virtual/stable/webexposed/global-interface-listing.html
>> >
>> > Those files are basically guards against accidentally exposing a new
>> > public-facing web API. You have to modify both of those to make it clear
>>
> that
>
>> > this change is intentional.
>>
>
>  Thanks for advise.
>> I'll check this issue asap.
>>
>
> @Dominic,
> I've updated new patchset.
> Now, can I try to commit this CL or do I need to get a review again?
> I wait your feedback.
>
> https://codereview.chromium.org/1007803002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-03-22 17:28:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-22 17:28:58]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[deejay, 2015-03-23 17:15:31]

The CQ bit was checked by djmix.kim@samsung.com

[commit-bot: I haz the power, 2015-03-23 17:15:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007803002/20001

[commit-bot: I haz the power, 2015-03-23 19:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-23 19:44:18]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[deejay, 2015-03-24 13:29:09]

On 2015/03/23 19:44:18, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_rel on tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

@Dominic,
I'm sorry that was still occured error on layout-test.
The parameter was listed in wrong order.

Also, I've checked complete with layout-test 
about "webexposed" and "virtual/stable/webexposed".
It works fine.

Please take a look this patch.

-----------------------------------------------------------
$ Tools/Scripts/run-webkit-tests webexposed
...
Found 14 tests; running 14, skipping 0.
Running 1 content_shell.                                                        
    
All 14 tests ran as expected. 
-----------------------------------------------------------
$ Tools/Scripts/run-webkit-tests virtual/stable/webexposed
...
Found 14 tests; running 14, skipping 0.
Running 1 content_shell.                                                        
    
All 14 tests ran as expected.
-----------------------------------------------------------

[dmazzoni, 2015-03-24 13:39:39]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-03-24 13:39:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1007803002/#ps40001
(title: "fix error on layout-test")

[commit-bot: I haz the power, 2015-03-24 13:39:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007803002/40001

[commit-bot: I haz the power, 2015-03-24 15:12:40]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192438

[tkent, 2015-03-24 22:18:03]

On 2015/03/19 05:04:34, haraken wrote:
> LGTM

Haraken should not approve web-exposed changes.

[haraken, 2015-03-24 23:37:00]

On 2015/03/24 22:18:03, tkent wrote:
> On 2015/03/19 05:04:34, haraken wrote:
> > LGTM
> 
> Haraken should not approve web-exposed changes.

Oh, sorry... I slipped on the review...