Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1007793002: Extract code to mark an object during incremental marking (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Extract code to mark an object during incremental marking Not only does this remove code duplication, I also plan to use this for unifying reference group marking later BUG=none R=hpayer@chromium.org LOG=n Committed: https://crrev.com/a6a887d083286aa1996122979e02d09c042a90fe Cr-Commit-Position: refs/heads/master@{#27180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M src/heap/incremental-marking.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.cc View 4 chunks +15 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-13 11:52:23 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 9 months ago (2015-03-13 12:04:50 UTC) #2
Hannes Payer (out of office)
lgtm lgtm
5 years, 9 months ago (2015-03-13 12:04:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007793002/1
5 years, 9 months ago (2015-03-13 12:05:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 12:14:06 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 12:14:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6a887d083286aa1996122979e02d09c042a90fe
Cr-Commit-Position: refs/heads/master@{#27180}

Powered by Google App Engine
This is Rietveld 408576698